Most of TdsParser is pretty similar. We've refactored a few methods, some of the members are in different orders and there are other cosmetic differences though, so this needs to be aligned before we can see where the true differences lie. This PR is the first of a few which do that. I'm fairly sure that once we've done that, only a few dozen lines of code will truly be different.

This dovetails with#2985, which handles some of the refactoring.

If someone from the SqlClient team can run CI, this should be enough to validate it. I don't expect that anything will have changed in the compiled DLL.

edwardneal added13 commits

March 16, 2025 22:06

Varying comments

d56b3a8

Merge using statements

76db279

Remove unnecessary fully-qualified type names

1d527d6

Merge => syntax for single-line method/property

6cb1fb0

Merged field naming convention

a531e78

Merge line break positions

493bc76

Merge varying variable names

773ff69

Merge sizeof and GUID_SIZE references

ea8120e

Merge single-line if blocks

845de04

Merge removal of "this."

eef6caf

Merge null coalescing

a838928

Merge exception handling

8a5aa7d

Mop-up: remove unused parameter from netfx, sync formatting

05d8a51

Copy link

Contributor

paulmedynski commentedMar 17, 2025

/azp run

Copy link

azure-pipelinesbot commentedMar 17, 2025

Azure Pipelines successfully started running 1 pipeline(s).

paulmedynski requested changes

Mar 17, 2025

View reviewed changes

Copy link

Contributor

paulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Need comment from@benrr101 regarding constrainted regions.

src/Microsoft.Data.SqlClient/netcore/src/Microsoft/Data/SqlClient/TdsParser.csShow resolvedHide resolved

Copy link

codecovbot commentedMar 17, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is50.29586% with84 lines in your changes missing coverage. Please review.

Project coverage is 66.02%. Comparing base(e0fa87b) to head(05d8a51).
Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs	34.37%	63 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs	71.23%	21 Missing⚠️

❗ There is a different number of reports uploaded between BASE (e0fa87b) and HEAD (05d8a51). Click for more details.
HEAD has 1 upload less than BASE
Flag BASE (e0fa87b) HEAD (05d8a51)
addons 1 0

Additional details and impacted files

@@            Coverage Diff             @@##             main    #3222      +/-   ##==========================================- Coverage   72.64%   66.02%   -6.63%==========================================  Files         288      282       -6       Lines       59600    59331     -269     ==========================================- Hits        43299    39173    -4126- Misses      16301    20158    +3857