Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup | LocalDbApi#3182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 3 commits intomainfromdev/russellben/cleanup/localdbapi
Mar 1, 2025
Merged

Conversation

benrr101
Copy link
Contributor

Description: Putting a cap on the LocalDbApi merge projects, this is the last PR that applies cleanup to the merge. Most changes are pretty benign, mostly involving renaming LocalDBApi to LocalDbApi as per Microsoft standard C# naming conventions.

Testing: Local tests continue to run as per the usual, CI should validate the rest of it.

@benrr101benrr101 added Code Health 💊Issues/PRs that are targeted to source code quality improvements. Common Project 🚮Things that relate to the common project project labelsFeb 26, 2025
@benrr101benrr101 added this to the7.0-preview1 milestoneFeb 26, 2025
@benrr101benrr101 requested a review froma teamFebruary 26, 2025 18:51
@codecovCodecov
Copy link

codecovbot commentedFeb 28, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is8.00000% with92 lines in your changes missing coverage. Please review.

Project coverage is 72.75%. Comparing base(dcf6ac4) to head(a8c47dc).
Report is 6 commits behind head on main.

Files with missing linesPatch %Lines
...osoft/Data/SqlClient/LocalDb/LocalDbApi.Windows.cs5.43%87 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs0.00%2 Missing⚠️
...ient/src/Microsoft/Data/SqlClient/SqlDependency.cs0.00%2 Missing⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs0.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3182      +/-   ##==========================================- Coverage   72.79%   72.75%   -0.05%==========================================  Files         283      285       +2       Lines       59139    59156      +17     ==========================================- Hits        43051    43037      -14- Misses      16088    16119      +31
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.45% <4.83%> (-0.08%)⬇️
netfx71.10% <8.16%> (-0.04%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@benrr101benrr101 merged commitbc59f58 intomainMar 1, 2025
252 checks passed
@benrr101benrr101 deleted the dev/russellben/cleanup/localdbapi branchMarch 1, 2025 00:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

3 participants
@benrr101@mdaigle@paulmedynski
[8]ページ先頭
©2009-2025 Movatter.jp