Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Improve DTC test stability#3181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdaigle merged 1 commit intomainfromdev/mdaigle/improve-dtc-test-stability
Feb 27, 2025

Conversation

mdaigle
Copy link
Contributor

I had originally thought that the outcome of TransactionAbortedException vs TransactionInDoubtException was dependent on sql server type (azure vs. local). However, I now understand that this is timing based and the azure database test invocations can also result in TransactionInDoubtException. Update the test to check for either of the expected error conditions.

@mdaiglemdaigle requested a review froma teamFebruary 26, 2025 18:38
@mdaiglemdaigle marked this pull request as ready for reviewFebruary 26, 2025 18:39
Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks pretty good to me.

@mdaiglemdaigle requested a review froma teamFebruary 26, 2025 22:40
@codecovCodecov
Copy link

codecovbot commentedFeb 26, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.80%. Comparing base(17cb0b0) to head(9828af2).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3181      +/-   ##==========================================- Coverage   72.96%   72.80%   -0.16%==========================================  Files         283      285       +2       Lines       58997    59137     +140     ==========================================+ Hits        43048    43057       +9- Misses      15949    16080     +131
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.53% <ø> (-0.20%)⬇️
netfx71.13% <ø> (-0.23%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@mdaiglemdaigle merged commite65635b intomainFeb 27, 2025
252 checks passed
@mdaiglemdaigle deleted the dev/mdaigle/improve-dtc-test-stability branchFebruary 27, 2025 15:58
@mdaiglemdaigle added this to the7.0-preview1 milestoneMar 21, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

3 participants
@mdaigle@benrr101@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp