Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cleanup/Merge | Remove Reliability Section#3164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

benrr101
Copy link
Contributor

This is a replacement of#3042 that will give us the complete CI

Description: After some discussion with@saurabh500 we came to the conclusion that it's just not beneficial to have the ReliabilitySection code in the netfx project. It is only included in debug builds (which we don't even use for CI builds anyhow), and it makes massive clutter in the code base. Although I've experimented with some ideas to leave it in place but cleanup the code, simply removing it is probably the easiest solution.

Testing: Project still builds without it and since it provides no functionality, it won't break anything to remove it.

@paulmedynski and@mdaigle, y'all already approved this one before :)

edwardneal reacted with rocket emoji
@benrr101benrr101 added Code Health 💊Issues/PRs that are targeted to source code quality improvements. Common Project 🚮Things that relate to the common project project labelsFeb 19, 2025
@benrr101benrr101 added this to the7.0-preview1 milestoneFeb 19, 2025
@codecovCodecov
Copy link

codecovbot commentedFeb 20, 2025
edited
Loading

Codecov Report

Attention: Patch coverage is62.46305% with381 lines in your changes missing coverage. Please review.

Project coverage is 72.73%. Comparing base(17cb0b0) to head(3d3ada8).
Report is 3 commits behind head on main.

Files with missing linesPatch %Lines
...core/src/Microsoft/Data/SqlClient/SqlDataReader.cs56.84%123 Missing⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlDataReader.cs57.04%122 Missing⚠️
...t/netfx/src/Microsoft/Data/SqlClient/SqlCommand.cs62.10%83 Missing⚠️
...icrosoft/Data/SqlClient/SqlDelegatedTransaction.cs61.01%23 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs43.75%18 Missing⚠️
...etfx/src/Microsoft/Data/SqlClient/SqlConnection.cs74.28%9 Missing⚠️
...crosoft/Data/SqlClient/SqlInternalConnectionTds.cs91.66%2 Missing⚠️
...fx/src/Microsoft/Data/SqlClient/TdsParser.netfx.cs0.00%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3164      +/-   ##==========================================- Coverage   72.96%   72.73%   -0.24%==========================================  Files         283      285       +2       Lines       58997    59192     +195     ==========================================+ Hits        43048    43054       +6- Misses      15949    16138     +189
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.51% <60.43%> (-0.22%)⬇️
netfx71.12% <64.65%> (-0.24%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@benrr101benrr101 merged commit083ae33 intomainFeb 20, 2025
252 checks passed
@benrr101benrr101 deleted the dev/russellben/merge/reliabilitysection-delete branchFebruary 20, 2025 21:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

3 participants
@benrr101@mdaigle@paulmedynski

[8]ページ先頭

©2009-2025 Movatter.jp