- Notifications
You must be signed in to change notification settings - Fork311
Cleanup/Merge | Remove Reliability Section#3164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
codecovbot commentedFeb 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@## main #3164 +/- ##==========================================- Coverage 72.96% 72.73% -0.24%========================================== Files 283 285 +2 Lines 58997 59192 +195 ==========================================+ Hits 43048 43054 +6- Misses 15949 16138 +189
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. |
083ae33
intomainUh oh!
There was an error while loading.Please reload this page.
This is a replacement of#3042 that will give us the complete CI
Description: After some discussion with@saurabh500 we came to the conclusion that it's just not beneficial to have the ReliabilitySection code in the netfx project. It is only included in debug builds (which we don't even use for CI builds anyhow), and it makes massive clutter in the code base. Although I've experimented with some ideas to leave it in place but cleanup the code, simply removing it is probably the easiest solution.
Testing: Project still builds without it and since it provides no functionality, it won't break anything to remove it.
@paulmedynski and@mdaigle, y'all already approved this one before :)