Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Cleanup | SNI Native Wrapper#3156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 12 commits intomainfromdev/russellben/cleanup/sni
Mar 10, 2025
Merged

Conversation

benrr101
Copy link
Contributor

This is a replacement of#3056 that will give us the complete CI

Description: This is a followup to the SNI Native Wrapper code merge. Each commit in this PR is an atomic change, so if the PR gets too cluttered to review all up, it can be stepped through one commit at a time. Most of these changes are just renaming and moving code around. One larger change is removing a bunch of private methods that were no longer necessary after extracting the DLL imports (as mentioned by@edwardneal).

Testing: There aren't really any functional changes here, so CI pass should be sufficient validation.

edwardneal reacted with thumbs up emoji
@benrr101benrr101 added Code Health 💊Issues/PRs that are targeted to source code quality improvements. Common Project 🚮Things that relate to the common project project labelsFeb 13, 2025
@benrr101benrr101 added this to the7.0-preview1 milestoneFeb 13, 2025
@benrr101benrr101 requested a review froma teamFebruary 13, 2025 21:55
@benrr101
Copy link
ContributorAuthor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynskipaulmedynski self-requested a reviewFebruary 20, 2025 19:55
@codecovCodecov
Copy link

codecovbot commentedFeb 20, 2025•
edited
Loading

Codecov Report

Attention: Patch coverage is92.06349% with15 lines in your changes missing coverage. Please review.

Project coverage is 72.52%. Comparing base(87b5435) to head(ac9be84).
Report is 4 commits behind head on main.

Files with missing linesPatch %Lines
...Client/src/Interop/Windows/Sni/SniNativeWrapper.cs95.41%5 Missing⚠️
...ient/src/Microsoft/Data/SqlClient/SqlDependency.cs75.00%4 Missing⚠️
...osoft/Data/SqlClient/LocalDb/LocalDbApi.Windows.cs0.00%2 Missing⚠️
...Data/SqlClient/TdsParserStateObject.Multiplexer.cs0.00%2 Missing⚠️
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs87.50%1 Missing⚠️
...ft/Data/Sql/SqlDataSourceEnumeratorNativeHelper.cs85.71%1 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3156      +/-   ##==========================================- Coverage   72.57%   72.52%   -0.05%==========================================  Files         288      289       +1       Lines       59526    59503      -23     ==========================================- Hits        43201    43156      -45- Misses      16325    16347      +22
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.08% <90.29%> (-0.01%)⬇️
netfx71.16% <91.71%> (-0.06%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@benrr101benrr101force-pushed thedev/russellben/cleanup/sni branch 2 times, most recently from5aa8c2c tobc5bc5bCompareMarch 4, 2025 01:35
@benrr101benrr101force-pushed thedev/russellben/cleanup/sni branch from12614c8 toac9be84CompareMarch 10, 2025 18:04
@benrr101benrr101 merged commit1e59b88 intomainMar 10, 2025
252 checks passed
@benrr101benrr101 deleted the dev/russellben/cleanup/sni branchMarch 10, 2025 22:52
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

3 participants
@benrr101@mdaigle@paulmedynski
[8]ページ先頭
©2009-2025 Movatter.jp