Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Disable failing TLS 1.0/1.1 tests#3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 3 commits intodotnet:mainfromedwardneal:correct-pr-3126
Jan 28, 2025

Conversation

edwardneal
Copy link
Contributor

Rolls up change from original connection test matrix#3127. Corrects#3126, removing its associated test.
CI is currently failing on main branch - it no longer supports TLS 1.0/1.1, so the tests which require TLS 1.2 are failing. This PR removes them.

Does not require porting to release/6.0.

cc@benrr101

benrr101 reacted with thumbs up emoji
Tests were failing in main branch - CI environment only supports TLS 1.2
@benrr101
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101benrr101 requested a review froma teamJanuary 22, 2025 23:32
Copy link
Contributor

@paulmedynskipaulmedynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

See comments in-file.

@edwardneal
Copy link
ContributorAuthor

Thanks@paulmedynski, I've addressed them. Would you mind triggering the pipeline again please?

@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedJan 24, 2025•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.10%. Comparing base(ebfbebb) to head(4782c74).
Report is 7 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (ebfbebb) and HEAD (4782c74). Click for more details.

HEAD has 5 uploads less than BASE
FlagBASE (ebfbebb)HEAD (4782c74)
addons50
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3130      +/-   ##==========================================- Coverage   72.72%   66.10%   -6.62%==========================================  Files         283      277       -6       Lines       58996    58687     -309     ==========================================- Hits        42905    38797    -4108- Misses      16091    19890    +3799
FlagCoverage Δ
addons?
netcore69.19% <ø> (-6.31%)⬇️
netfx64.86% <ø> (-6.33%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@benrr101
Copy link
Contributor

@edwardneal I'm not 100% sure about these failures, but can you merge/rebase from main and we can try again?@David-Engel made some changes that should fix running CI pipelines from forks

@edwardneal
Copy link
ContributorAuthor

I've just done that. The pipeline hasn't run automatically though, so needs another trigger.

@cheenamalhotra
Copy link
Member

/azp run

edwardneal reacted with rocket emoji

@cheenamalhotracheenamalhotra added this to the7.0-preview1 milestoneJan 26, 2025
@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@benrr101
Copy link
Contributor

Ok, it all looks good to me 🚢

edwardneal reacted with hooray emoji

@benrr101benrr101 merged commit82edd8b intodotnet:mainJan 28, 2025
123 checks passed
@edwardnealedwardneal deleted the correct-pr-3126 branchJanuary 28, 2025 18:05
benrr101 pushed a commit that referenced this pull requestMar 4, 2025
* Reverted changes to connection test matrixTests were failing in main branch - CI environment only supports TLS 1.2* Remove const from ConnectionTestParametersData
benrr101 pushed a commit that referenced this pull requestMar 4, 2025
* Reverted changes to connection test matrixTests were failing in main branch - CI environment only supports TLS 1.2* Remove const from ConnectionTestParametersData
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

4 participants
@edwardneal@benrr101@paulmedynski@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp