/azp run

/azp run

@ErikEJ looking into the test failures more, it looks like they're genuine failures of the test related to the changes you made. The value itself looks to be correct but the formatting is wrong. Looks like it's possible the assert isn't doing the right comparison?

@benrr101 Thanks - it is SO hard to locate the actual errors

@benrr101 I had made the .NET Framework test pass locally 😆

@benrr101 Tests are passing now!

/azp run

@ErikEJ Hmm, it looks like there's still an issue with the cast on netfx
https://sqlclientdrivers.visualstudio.com/public/_build/results?buildId=109151&view=logs&j=166c4da6-b55b-5799-fbde-21502bcb70ff&t=a381c7c1-6591-5f42-6a10-14c2761ba4c4&l=700

@benrr101 OMG - the pipeline never ran - I will investigate, thanks

@dotnet/sqlclientdevteam Pls kick the CI 🙏

/azp run

@benrr101 Failing test seems unrelated ??

@benrr101 Failing test seems unrelated ??

Agreed, it seems to be so. I'll proceed to kick it until its behavior improves.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.14%. Comparing base(081fc51) to head(595c898).
Report is 9 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (081fc51) and HEAD (595c898). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (081fc51)	HEAD (595c898)
addons	1	0

@@            Coverage Diff             @@##             main    #3128      +/-   ##==========================================- Coverage   72.73%   66.14%   -6.59%==========================================  Files         283      279       -4       Lines       58997    58945      -52     ==========================================- Hits        42910    38989    -3921- Misses      16087    19956    +3869

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.