Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Tests | Activate SplitPacket Tests#3061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
mdaigle merged 4 commits intodotnet:mainfromMichelZ:pr/activate-splitpackettest
Apr 24, 2025

Conversation

MichelZ
Copy link
Contributor

AI Blurp

This pull request includes several improvements and refactorings to theSplitPacketTest class and theDataTestUtility class in the Microsoft.Data.SqlClient test suite. The most important changes include adding new utility methods, refactoring existing methods, and enhancing the test class with proper resource disposal.

Improvements and refactorings:

Enhancements to test class:

These changes enhance the code readability, maintainability, and ensure that resources are properly managed during the tests.

Human stuff

This removes the ActiveIssue 5538 from the SplitPacketTest
It makes sure that the test is only run on localhost and without named instances due to the fact that the tests are proxying the requests.

Also added IDisposable cleanup so that the started threads don't hang around.

@MichelZ
Copy link
ContributorAuthor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Commenter does not have sufficient privileges for PR 3061 in repo dotnet/SqlClient

@paulmedynskipaulmedynski requested a review froma teamMarch 18, 2025 14:36
@paulmedynski
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulmedynskipaulmedynski self-assigned thisMar 21, 2025
@paulmedynskipaulmedynski added this to the6.1-preview1 milestoneApr 2, 2025
@mdaiglemdaigle self-assigned thisApr 2, 2025
@benrr101
Copy link
Contributor

/azp run

@azure-pipelinesAzure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@codecovCodecov
Copy link

codecovbot commentedApr 24, 2025
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.12%. Comparing base(bb4c3b7) to head(54ee201).
Report is 98 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (bb4c3b7) and HEAD (54ee201). Click for more details.

HEAD has 1 upload less than BASE
FlagBASE (bb4c3b7)HEAD (54ee201)
addons10
Additional details and impacted files
@@            Coverage Diff             @@##             main    #3061      +/-   ##==========================================- Coverage   72.68%   66.12%   -6.57%==========================================  Files         283      292       +9       Lines       58975    56691    -2284     ==========================================- Hits        42864    37485    -5379- Misses      16111    19206    +3095
FlagCoverage Δ
addons?
netcore69.01% <ø> (-6.47%)⬇️
netfx65.12% <ø> (-6.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

🚀 New features to boost your workflow:
  • ❄️Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mdaiglemdaigle merged commitf2a8cd2 intodotnet:mainApr 24, 2025
136 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@paulmedynskipaulmedynskipaulmedynski approved these changes

Labels
None yet
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

4 participants
@MichelZ@paulmedynski@benrr101@mdaigle

[8]ページ先頭

©2009-2025 Movatter.jp