- Notifications
You must be signed in to change notification settings - Fork311
Tests | Split MultipleResultsTest, clean up console logging#3060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Also adjusted certificate generation, it's redirecting standard errors and not always loading the user profile.
| @@ -76,7 +76,6 @@ public void CustomActiveDirectoryProviderTest_AppClientId_DeviceFlowCallback() | |||
| private Task CustomDeviceFlowCallback(DeviceCodeResult result) | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It would help readability if we remove this method. It's not doing anything useful now that the logging is removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks, I've removed it. Can you trigger another CI run please?
/azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
codecovbot commentedFeb 20, 2025 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@## main #3060 +/- ##==========================================- Coverage 72.81% 66.21% -6.61%========================================== Files 282 276 -6 Lines 59112 58802 -310 ==========================================- Hits 43045 38933 -4112- Misses 16067 19869 +3802
Flags with carried forward coverage won't be shown.Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is awesome, I love anything that breaks up complicated tests and cleans up the console output on the tests. 🚀
Would love to see the few comments I made addressed, but I also won't hold things up if you don't want to address them.
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
...Data.SqlClient/tests/ManualTests/ProviderAgnostic/MultipleResultsTest/MultipleResultsTest.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
/azp run |
| Azure Pipelines successfully started running 1 pipeline(s). |
87b5435 intodotnet:mainUh oh!
There was an error while loading.Please reload this page.
This starts to adjust the way the SqlClient tests use the console stdout. It contains two changes.
MultipleResultsTest rework
This was one large method. It would temporarily replace the console stdout, log to it, then manually perform a diff between the stdout and a file bundled with the project.
I've modified this, splitting the large method into three tests (ExecuteNonQuery, ExecuteReader, ExecuteScalar.) These tests are designed to prove the way that SqlClient handles informational messages, exceptions and result sets when MARS is enabled.
Console stdout rework
I've noticed a few instances where standard output from the TDS servers get mixed in with the test results logged in the CI pipeline. This output isn't useful, even when the tests fail; I've disabled it in a few areas.