Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Remove RelationshipConverter#3023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

benrr101
Copy link
Contributor

Description: This class isn't being used - we should delete it! 🚮

Testing: Project builds just fine without, should be good to delete.

... Is this a merge PR or a cleanup PR. I mean I'm technically merging it into the great codebase in the sky (and I don't just mean the cloud), and we're consolidating it between netfx and netcore (that doesn't have it)

edwardneal reacted with rocket emoji
@benrr101benrr101 added Code Health 💊Issues/PRs that are targeted to source code quality improvements. Common Project 🚮Things that relate to the common project project labelsNov 20, 2024
@codecovCodecov
Copy link

codecovbot commentedNov 20, 2024•
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.70%. Comparing base(1b9df10) to head(e1503ab).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@##             main    #3023      +/-   ##==========================================+ Coverage   72.64%   72.70%   +0.05%==========================================  Files         285      284       -1       Lines       59160    59155       -5     ==========================================+ Hits        42979    43008      +29+ Misses      16181    16147      -34
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.42% <ø> (+0.03%)⬆️
netfx71.14% <ø> (+0.05%)⬆️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@benrr101benrr101 merged commitb9877f4 intodotnet:mainNov 26, 2024
82 checks passed
@benrr101benrr101 deleted the merge/relationship-converter branchNovember 26, 2024 19:05
@cheenamalhotracheenamalhotra added this to the6.0.0 milestoneApr 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@mdaiglemdaiglemdaigle approved these changes

@David-EngelDavid-EngelDavid-Engel approved these changes

@cheenamalhotracheenamalhotraAwaiting requested review from cheenamalhotra

@samsharma2700samsharma2700Awaiting requested review from samsharma2700

Assignees
No one assigned
Labels
Code Health 💊Issues/PRs that are targeted to source code quality improvements.Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.0.0
Development

Successfully merging this pull request may close these issues.

4 participants
@benrr101@mdaigle@David-Engel@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp