Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Move ReliabilitySection / BestEffortCleanup to framework specific files#2984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

MichelZ
Copy link
Contributor

I don't think we want to wrap those in #IF NETFRAMEWORK / NETCORE conditional compiles, it makes sense to have them in their own files, so I've moved them out of the "future-common-project" file(s)

Part of#2953

@codecovCodecov
Copy link

codecovbot commentedNov 7, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is37.03704% with34 lines in your changes missing coverage. Please review.

Project coverage is 72.67%. Comparing base(1b9df10) to head(f97eaf4).
Report is 8 commits behind head on main.

Files with missing linesPatch %Lines
...fx/src/Microsoft/Data/SqlClient/TdsParser.netfx.cs39.21%31 Missing⚠️
.../src/Microsoft/Data/SqlClient/TdsParser.netcore.cs0.00%3 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2984      +/-   ##==========================================+ Coverage   72.64%   72.67%   +0.02%==========================================  Files         285      286       +1       Lines       59160    59160              ==========================================+ Hits        42979    42995      +16+ Misses      16181    16165      -16
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.44% <0.00%> (+0.05%)⬆️
netfx71.07% <39.21%> (-0.02%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

@MichelZMichelZforce-pushed thetdsparser-move-netcorenetfxcode branch fromc634c01 toac8aa33CompareNovember 7, 2024 13:53
Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall I think this makes sense and is probably a good idea. Still not a huge fan of the conditional attribute, but since it's already there, I won't raise a fuss :)

@benrr101benrr101 added the Common Project 🚮Things that relate to the common project project labelNov 14, 2024
@benrr101
Copy link
Contributor

@MichelZ if you can resolve the conflict, I can get this merged 🚢

@MichelZ
Copy link
ContributorAuthor

@benrr101 Done! Thx

@MichelZMichelZ changed the titleMove ReliabilitySection / BestEffortCleanup to framework specific filesMerge | Move ReliabilitySection / BestEffortCleanup to framework specific filesNov 24, 2024
@benrr101benrr101 added this to the6.0.0 milestoneNov 25, 2024
@benrr101benrr101 merged commit5519887 intodotnet:mainNov 25, 2024
82 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@cheenamalhotracheenamalhotracheenamalhotra approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

3 participants
@MichelZ@benrr101@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp