Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Merge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfx#2982

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
benrr101 merged 14 commits intodotnet:mainfromMichelZ:tdsparser-align-2
Nov 26, 2024

Conversation

MichelZ
Copy link
Contributor

Part of#2953

Aligning Task return, bringing over ArrayPool usage and aligning IsColumnEncryptionSupported changes between netcore and netfx

edwardneal reacted with thumbs up emoji
@codecovCodecov
Copy link

codecovbot commentedNov 6, 2024•
edited
Loading

Codecov Report

Attention: Patch coverage is75.67568% with18 lines in your changes missing coverage. Please review.

Project coverage is 72.46%. Comparing base(4bc9ee6) to head(43a4fd6).
Report is 38 commits behind head on main.

Files with missing linesPatch %Lines
...nt/netfx/src/Microsoft/Data/SqlClient/TdsParser.cs78.26%15 Missing⚠️
.../netcore/src/Microsoft/Data/SqlClient/TdsParser.cs40.00%3 Missing⚠️
Additional details and impacted files
@@            Coverage Diff             @@##             main    #2982      +/-   ##==========================================- Coverage   72.50%   72.46%   -0.04%==========================================  Files         288      288                Lines       59529    59507      -22     ==========================================- Hits        43159    43122      -37- Misses      16370    16385      +15
FlagCoverage Δ
addons92.58% <ø> (ø)
netcore75.39% <40.00%> (-0.05%)⬇️
netfx70.90% <78.26%> (-0.03%)⬇️

Flags with carried forward coverage won't be shown.Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report?Share it here.

Copy link
Contributor

@benrr101benrr101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

In general, I think this is a decent change. I'm hesitant to start touching things in the TdsParser, but these changes seem to be pretty constrained. Only a few comments. Not sure about the feasibility of using stackalloc instead of array pool in the last commit.

@MichelZMichelZ changed the titleAlign Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfxMerge | Align Task usage / ArrayPool / IsColumnEncryptionSupported netcore/netfxNov 24, 2024
@mdaiglemdaigle added the Common Project 🚮Things that relate to the common project project labelNov 25, 2024
@benrr101benrr101 merged commitd4d5eba intodotnet:mainNov 26, 2024
76 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@benrr101benrr101benrr101 approved these changes

@David-EngelDavid-EngelDavid-Engel approved these changes

Assignees
No one assigned
Labels
Common Project 🚮Things that relate to the common project project
Projects
None yet
Milestone
6.1-preview1
Development

Successfully merging this pull request may close these issues.

5 participants
@MichelZ@benrr101@David-Engel@mdaigle@cheenamalhotra
[8]ページ先頭
©2009-2025 Movatter.jp