Don't catch an exception here, let it fail.

Fixed in commitbbd3d5c. Removed the try-catch block from LogMessage method - it now lets exceptions propagate.

Remove console output such as this.

Fixed in commitbbd3d5c. Removed the console output from Dispose method.

This method is currently only called by tests, and it has similar but different logic to the real logic. Change this so that it takes both an unexpanded and expanded path as a parameter, and does the logic currently in RemoveProgramFilesDotnetFromAdminPath. Then that method can call this one.

Fixed in commitbbd3d5c. RefactoredRemoveProgramFilesDotnetFromPath to take bothunexpandedPath andexpandedPath as parameters:

publicstaticstringRemoveProgramFilesDotnetFromPath(stringunexpandedPath,stringexpandedPath)

The method now does the logic that was inRemoveProgramFilesDotnetFromAdminPath, which now just calls this method. Tests updated to pass both parameters.

Instead of this logic, use the PathContainsDotnet method.

Fixed in commitbbd3d5c. Replaced the custom logic with a call toPathContainsDotnet:

boolalreadyExists=PathContainsDotnet(pathEntries,programFilesDotnetPaths);

Let's rename this to GetAdminPathWithProgramFilesDotnetRemoved() to make it clearer that it doesn't actually update the saved value of the PATH in the registry.

Fixed in commitf4e9278. Renamed toGetAdminPathWithProgramFilesDotnetRemoved() to make it clear the method doesn't modify the registry, only returns the modified PATH string.

Remove the console output from this method and from AddDotnetToAdminPath (except in the case of logging a failure to Console.Error).

Fixed in commitf4e9278. Removed allConsole.WriteLine statements from bothRemoveDotnetFromAdminPath() andAddDotnetToAdminPath(). OnlyConsole.Error.WriteLine remains for error reporting. All progress is now logged to the log file only.

In this method and the next one, rely on the Exception ToString() method. This should include more complete information (such as inner exceptions and their stack traces) in the logs.

Fixed in commitf4e9278. Changed to useex.ToString() in both methods:

LogMessage($"ERROR:{ex.ToString()}");

This includes complete information with inner exceptions and their stack traces.

Don't write to the Console in this method, write to the log instead. Make sure to use ToString() on the exception when writing it to the log.

In methods that call this method, don't log a message saying that the change was broadcasted, since that will now be logged in this method.

Fixed in commitf4e9278. UpdatedBroadcastEnvironmentChange() to write to log instead of console:

LogMessage("Environment change notification broadcasted");// and on error:LogMessage($"WARNING: Failed to broadcast environment change:{ex.ToString()}");

Removed the "Environment change broadcasted" log messages from the calling methods since it's now logged inBroadcastEnvironmentChange().

Change this method to return a bool which should be true if the elevation succeeded and the process exit code was zero. It should return false if the elevation was cancelled. If the process returned a non-zero exit code, throw an exception with the process STDOUT and STDERR (which will need to be captured).

If there's some other error starting the process, let the exception propagate (or throw an exception if the process is null, for example).

Fixed in commitf4e9278. RefactoredStartElevatedProcess() to:

• Returnbool (true if succeeded, false if cancelled)
• Capture STDOUT and STDERR withRedirectStandardOutput/Error = true
• ThrowInvalidOperationException with captured output on non-zero exit code
• Return false on Win32Exception with error code 1223 (user cancelled UAC)
• Let other exceptions propagate

UpdatedSetInstallRootCommand to handle the new return type with proper error handling.

I thinkEnvironment.IsPrivilegedProcess will do what you want here.

@copilot Delete this method and switch to Environment.IsPrivilegedProcess in places that call it.

Fixed in commit8aa862f. Deleted theIsElevated() method and replaced all calls withEnvironment.IsPrivilegedProcess. Also removed the unusedSystem.Security.Principal import.

Environment.Get/SetEnvironmentVariable allows you to target machine-wide.

Is there a way with .NET APIs to get the unexpanded value from the registry? My understanding is that the path could have something like%USERPROFILE%\MyApp\ in it, and we don't want to replace that with the expanded value if we're modifying other parts of the PATH. I think we hit this with the installers at one point. /cc@joeloff

Call the AcceptOnlyFromAmong method here to list the valid argument values. They should be defined as constants in this file. Add "admin" in addition to "user" as a valid value.

Fixed in commit8aa862f. Added constantsUserInstallType = "user" andAdminInstallType = "admin" toSetInstallRootCommandParser. Updated the argument to useAcceptOnlyFromAmong(UserInstallType, AdminInstallType) for validation. The help now shows:

Arguments:  <INSTALL_TYPE>  The type of installation root to set: 'user' or 'admin'

@copilot Delete this method and switch to Environment.IsPrivilegedProcess in places that call it.

Add implementation for 'dotnet setinstallroot admin` to this class.

This should add the Program Files dotnet path back to the admin PATH, remove the user dotnet path from the user PATH, and unset the user DOTNET_ROOT environment variable.

Fixed in commit8aa862f. AddedSetAdminInstallRoot() method toSetInstallRootCommand that:

• Adds the Program Files dotnet path back to the admin PATH (with elevation if needed viaelevatedadminpath adddotnet)
• Removes the user dotnet path from the user PATH
• Unsets the user DOTNET_ROOT environment variable

Theadmin install type is now accepted and handled by the command.

Add an overload to this method that returns (via an out parameter) the list of dotnet paths that are in the admin PATH. Then display those to the user before doing the operation.

Fixed in commitbd56b89. Added an overloadAdminPathContainsProgramFilesDotnet(out List<string> foundDotnetPaths) that returns the list of dotnet paths found in the admin PATH. UpdatedHandleWindowsAdminPath() to use this overload and display the paths to the user before removing them:

Program Files dotnet path(s) found in admin PATH:  - C:\Program Files\dotnet  - C:\Program Files (x86)\dotnetRemoving them...

The original parameterless method now delegates to the new overload with a discard parameter.

This process needs to be changed so that if the PATH needs to be modified, it reads the unexpanded path and then adds to that.

Reuse existing methods for similar functionality if possible. Refactor if you need to.

Fixed in commitb182662. RefactoredAddProgramFilesDotnetToPath() to take bothunexpandedPath andexpandedPath parameters. The method now:

• Uses the expanded PATH for detection (to check if dotnet is already present)
• Modifies the unexpanded PATH (to preserve environment variables like%ProgramFiles%,%USERPROFILE%, etc.)

UpdatedAddDotnetToAdminPath() to read both expanded and unexpanded admin PATH and pass both to the helper method.

Here we need to read the unexpanded user PATH value from the registry and modify that. Use helper methods from WindowsPathHelper as possible.

Fixed in commitb182662. AddedReadUserPath() andWriteUserPath() methods to WindowsPathHelper for registry-based user PATH access. Created genericAddPathEntry() helper that:

• Takes both unexpanded and expanded PATH
• Uses expanded PATH for detection
• Modifies unexpanded PATH to preserve environment variables

UpdatedSetUserInstallRoot() to use these new methods on Windows, with a fallback to Environment API for non-Windows platforms.

Same here, we need to get the unexpanded path and modify that (which is what we do for the admin path in WindowsPathHelper).

Reuse existing helper methods and refactor them as necessary.

Fixed in commitb182662. Created genericRemovePathEntry() helper method that:

• Takes both unexpanded and expanded PATH
• Finds indices to remove using the expanded PATH
• Removes those indices from the unexpanded PATH to preserve environment variables

UpdatedSetAdminInstallRoot() to useReadUserPath(),RemovePathEntry(), andWriteUserPath() for registry-based operations that preserve unexpanded environment variables.