- Notifications
You must be signed in to change notification settings - Fork1.2k
Add RuntimeHostConfigurationOption for COM descriptor support#40106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
LakshanF approved these changesApr 10, 2024
Member
eerhardt commentedApr 10, 2024
@sbomer - what's the default value for this new feature switch? It is currently blocking ingesting the latest runtime in dotnet/aspnetcore -dotnet/aspnetcore#55010 |
MemberAuthor
sbomer commentedApr 10, 2024
It'll be disabled by default for trimmed apps withdotnet/runtime#100881 and this change. |
sbomer added a commit to dotnet/runtime that referenced this pull requestApr 10, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.Depends on the SDK changedotnet/sdk#40106.
3 tasks
matouskozak pushed a commit to matouskozak/runtime that referenced this pull requestApr 30, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.Depends on the SDK changedotnet/sdk#40106.
Ruihan-Yin pushed a commit to Ruihan-Yin/runtime that referenced this pull requestMay 30, 2024
Defaults the COM type descriptor feature switch to false in trimmed apps.Depends on the SDK changedotnet/sdk#40106.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds SDK logic for the feature switch introduced indotnet/runtime#100693. Depends ondotnet/runtime#100881.
Together withdotnet/runtime#100881,fixesdotnet/runtime#100862.