- Notifications
You must be signed in to change notification settings - Fork1.2k
[main] Update dependencies from dotnet/runtime#16810
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[main] Update dependencies from dotnet/runtime#16810
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…0409.1Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21209.1
ghost commentedApr 9, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
jeffschwMSFT commentedApr 9, 2021
Rerunning as there were 5 sdk tests failures |
jeffschwMSFT commentedApr 9, 2021
This round seems to fail due to restore failures: A connection attempt failed because the connected party did not properly respond after a period of time, or established connection failed because connected host has failed to respond. C:\h\w\B5080A10\p\d\sdk\6.0.100-ci\Sdks\Microsoft.NET.Sdk\targets\Microsoft.PackageDependencyResolution.targets(241,5): error MSB4018: The "ResolvePackageAssets" task failed unexpectedly. |
jeffschwMSFT commentedApr 9, 2021
@marcpopMSFT are you seeing in stability across the sdk repo? This pr seems to be in a whack a mole issue hunt with azure. Here is a new one: python.exe -c "import future" || C:\Users\runner.azdo-env\Scripts\python.exe -m pip install future==0.17.1 |
marcpopMSFT commentedApr 9, 2021
@jeffschwMSFT we have been having a lot of stability issues mainly related to ADO feeds throttling us and overlapping test directories. They've increased the limits for us, we've fixed the test directory at the beginning of this week, and added a retry on restore such that at least earlier this week, our reliability was looking very good. Today though is having a lot of issues so I'm not sure if there is system problem today or we just got lucky earlier in the week. @dsplaisted is on build duty. Given the high number of failures in this run (we usually see a smaller number), might be a system problem or an issue in the payload. |
jeffschwMSFT commentedApr 9, 2021
@dsplaisted will you get a chance to take a look? The current set of failures look different than the last set, which is true of the first set. |
dsplaisted commentedApr 9, 2021
@jeffschwMSFT This looks like it might be a break in the runtime that is being inserted. I'm seeing a failure down in the System.IO code:
Is this the failure you were seeing? |
jeffschwMSFT commentedApr 9, 2021
Only on this most recent retry. I don't have the previous logs, but I do not think it was due to this. Adding@jeffhandley . |
…0409.14Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21209.14
…0411.1Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21211.1
…0411.7Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21211.7
jeffschwMSFT commentedApr 12, 2021
jeffhandley commentedApr 12, 2021
@adamsitnik@carlossanlop@jozkee -- These errors look to be caused by the recent changes to Here's the trimmed up call stack: |
adamsitnik commentedApr 12, 2021 • edited by carlossanlop
Loading Uh oh!
There was an error while loading.Please reload this page.
edited by carlossanlop
Uh oh!
There was an error while loading.Please reload this page.
@carlossanlop@jozkee repro: git clone https://github.com/dotnet/sdk reprocd reprogit checkout darc-main-0fd96bf7-148d-4cf6-97b0-d3934c67609e.\build.cmd -c Debug.\.dotnet\dotnet.exe test -c Debug src\Tests\Microsoft.NET.Build.Tests\Microsoft.NET.Build.Tests.csproj --filter Microsoft.NET.Build.Tests.GivenThatWeWantToBuildASelfContainedApp.It_succeeds_when_RuntimeIdentifier_and_PlatformTarget_mismatch_but_PT_is_AnyCPU |
carlossanlop commentedApr 12, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@jeffschwMSFT@marcpopMSFT we have aruntime PR out to revert the compat flag that enabled the new FileStream rewrite by default. This will unblock dotnet/sdk and will allow us to investigate the root cause more carefully. |
marcpopMSFT commentedApr 12, 2021
Thanks@carlossanlop. Please prioritize getting that in and flowing as this PR is needed to unblockeddotnet/installer#10185 and I need a new build of installer with runtime changes to insert into VS previews as well. CC@joeloff |
carlossanlop commentedApr 12, 2021
carlossanlop commentedApr 13, 2021
The PR with the fix was merged. Is dotnet-maestro going to update this PR automatically with the commit that contains the fix, or do we need to do something manually? |
joeloff commentedApr 13, 2021
Hopefully it is updated by maestro once a new runtime build is ready |
…0413.1Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21213.1
jeffschwMSFT commentedApr 13, 2021
Thanks@carlossanlop. The current failures are due to a missing browswer wasm package. /private/tmp/helix/working/ABAC0950/w/B36A0A16/e/testExecutionDirectory/BuildMinimal_---F77D8391/blazorwasm-minimal.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.browser-wasm with version (= 6.0.0-preview.4.21213.1) @marek-safar@steveisok can y'all take a look at what is missing? |
marek-safar commentedApr 13, 2021
@steveisok that's the renaming issue, right? |
steveisok commentedApr 13, 2021
Yes, we are working on fixing |
…0413.3Microsoft.NETCore.Platforms , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.DotNetHostResolver , Microsoft.NET.HostModel , Microsoft.Extensions.DependencyModel , Microsoft.NETCore.App.Host.win-x64 , Microsoft.NETCore.App.Ref , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.CodeDom , VS.Redist.Common.NetCore.SharedFramework.x64.6.0 , System.Security.Cryptography.ProtectedData , System.Text.Encoding.CodePages From Version 6.0.0-preview.4.21207.11 -> To Version 6.0.0-preview.4.21213.3
jeffschwMSFT commentedApr 13, 2021
@steveisok the run just finished and we are now seeing the following: Unable to find package Microsoft.NETCore.App.Runtime.browser-wasm with version (= 6.0.0-preview.4.21213.3) |
akoeplinger commentedApr 13, 2021
@jeffschwMSFTdotnet/installer#10206 is part of the fix. |
marcpopMSFT commentedApr 13, 2021
Installer change is merged now. |
pranavkm commentedApr 13, 2021
@marcpopMSFT would unblocking this PR need a new stage0 SDK? |
marcpopMSFT commentedApr 13, 2021
@pranavkm The changes made to OverrideAndCreateBundledNETCoreAppPackageVersion.cs allow them to avoid needing a stage 0 update. It basically adds the changes that would be from the new installer build to avoid the sdk vs. installer deadlock. |
marcpopMSFT commentedApr 13, 2021
@dotnet/dnceng The Ubuntu build has been queued for an hour now without starting. Is there an issue in the lab with resources or too many builds at once? |
ulisesh commentedApr 13, 2021
@marcpopMSFT yes, the queue is its max capacity limit. I just scaled the queue over this limit to speed things up. FYI, the capacity limit will be increased tomorrow to prevent this. |
markwilkie commentedApr 13, 2021
What's the best way for folks like@marcpopMSFT to look at the queue depth themselves? |
ulisesh commentedApr 13, 2021
There is a Helix API call that you can do to get the queueDepth You can callhttps://helix.dot.net/api/info/queues/buildpool.ubuntu.1604.amd64.open?includeQueueDepth=true&api-version=2019-06-17 but it looks like the information isn't correct.@MattGal@alexperovich do you know if we stopped supporting this? |
MattGal commentedApr 13, 2021
new to me, checking it out. |
MattGal commentedApr 13, 2021
Um. I think it's an artifact from when@alexperovich rewrote the API? The old one has it thenewer one doesn't really |
MattGal commentedApr 13, 2021
It's intentional on both API versions: ... looks like updating SDKs took away functionality, sorry users! |
markwilkie commentedApr 13, 2021
Remind me again what we use for our grafana alerting? |
ulisesh commentedApr 13, 2021
Our monitoring system definitely has the queue depth information@marcpopMSFT was looking for. I'll share it with him but it isn't recommended approach for all users |
MattGal commentedApr 13, 2021
it probably just uses the old SDK where that API was still available. |
markwilkie commentedApr 13, 2021 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
That makes sense. Marc could just use that too yes? |
MattGal commentedApr 13, 2021
Correct, we just don't usually point users at Grafana as@ulisesh said. |
marcpopMSFT commentedApr 13, 2021
@markwilkie PR improvement suggestion to show the queue in the new PR experience. I can certainly use the dashboard or api but I'll likely forget before the next time it gets backed up on a high visibility change. |
markwilkie commentedApr 13, 2021
@garath /@missymessa - could one of you make sure we're tracking the suggestion to add queue depth to the PR experience please? @marcpopMSFT - it'll be good to track this, but given that the build won't even have started, it'll be tough to show results of something that hasn't started yet. :) Sounds like you could make an API call as well.... @garath /@ilyas1974 - what's the latest thinking around opening up grafana for more folks to see. My thinking is to allow folks to self-help queue depth. thoughts? |
ilyas1974 commentedApr 13, 2021
No issues on my side opening up Grafana to more of our customers to view queue status. Is the scenario you're thinking about something like - my build didn't start properly (i.e. couldn't get a machine before timeout) and in the failure we also show what the current queue depth is? |
jeffschwMSFT commentedApr 13, 2021
woot! Thanks everyone |
marcpopMSFT commentedApr 13, 2021
My scenario was: "All the builds are started except for Ubuntu. Why is it still queued and how long should I expect to wait?" That's why I pinged dnceng in the first place as this PR was blocking an installer PR which was blocking a VS PR....lots waiting for it to get fixed. |
markwilkie commentedApr 14, 2021
Is opening up grafana something you can follow up on by any chance@ilyas1974 ? Probably check w/@Chrisboh etc to see what (if anything) we need to think about. If you're full up, I can do it as well, just let me know. |
ilyas1974 commentedApr 14, 2021
Happy to help to drive this. @marcpopMSFT, for your specific scenario, hooking into Grafana may not provide the answers you are looking for.
|
garath commentedApr 22, 2021
I've opened dotnet/core-eng#12899 in the epic to track. |
Uh oh!
There was an error while loading.Please reload this page.
This pull request updates the following dependencies
Fromhttps://github.com/dotnet/runtime