- Notifications
You must be signed in to change notification settings - Fork215
[NativeAOT-LLVM] Fix a GC hole in the new LSSA implementation#2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
jkotas merged 3 commits intodotnet:feature/NativeAOT-LLVMfromSingleAccretion:LSSA-Gc-HoleMar 24, 2024
Merged
[NativeAOT-LLVM] Fix a GC hole in the new LSSA implementation#2531
jkotas merged 3 commits intodotnet:feature/NativeAOT-LLVMfromSingleAccretion:LSSA-Gc-HoleMar 24, 2024
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
We need to be careful about not depending on stale shadow stackstate when making decision not to spill a def derived from analready spilled value.This has some cost, but an overly large one, about 0.15% in termsof code size for HelloWasm.
Without the fix, this test quickly crashed under stress.With the fix, it passes without issue.
Author
SingleAccretion commentedMar 23, 2024
@dotnet/nativeaot-llvm |
yowl approved these changesMar 23, 2024
Contributor
yowl left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I'm not claiming to have a good understanding of this, but the coverage looks good.
Member
jkotas commentedMar 24, 2024
Thank you! |
38 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
We need to be careful about not depending on stale shadow stack state when making decisions not to spill a def derived from an already spilled value.
This has some cost, but an overly large one, about 0.15% in terms of code size for HelloWasm.
Ref:#2514 (comment).