Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

set scope and build validation in dev when no options provided#99199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
steveharter merged 17 commits intodotnet:mainfromwcsanders1:issue-97091
Jul 8, 2024

Conversation

@wcsanders1
Copy link
Contributor

Resolves issue#97091

@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-extensions-hosting
See info inarea-owners.md if you want to be subscribed.

Issue Details

Resolves issue#97091

Author:wcsanders1
Assignees:-
Labels:

area-Extensions-Hosting

Milestone:-

@stevehartersteveharter self-requested a reviewMarch 7, 2024 21:33
@buyaa-n
Copy link
Contributor

@benjaminpetit could you take a look please?

@stevehartersteveharter merged commit673a664 intodotnet:mainJul 8, 2024
@ericstjericstj added the breaking-changeIssue or PR that represents a breaking API or functional change over a previous release. labelJul 19, 2024
@dotnet-policy-servicedotnet-policy-servicebot added the needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet labelJul 19, 2024
@dotnet-policy-service
Copy link
Contributor

dotnet-policy-servicebot commentedJul 19, 2024•
edited by ericstj
Loading

Addedneeds-breaking-change-doc-created label because this PR has thebreaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using thebreaking change documentation template, then remove thisneeds-breaking-change-doc-created label.
  2. Ask a committer to mail the.NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

publicHostBuilder()
{
_serviceProviderFactory=newServiceFactoryAdapter<IServiceCollection>(newDefaultServiceProviderFactory());
_defaultProviderFactoryUsed=true;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Where is this ever set to false? Should that be done inUseServiceProviderFactory?

Copy link
ContributorAuthor

@wcsanders1wcsanders1Jul 20, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Yes, it seems to me that this field should be set to false whenUseServiceProviderFactory is called. This was my oversight I believe.

@ericstj
Copy link
Member

I marked this PR as breaking since it introduces new validation by default when in Development environment.

@ericstj
Copy link
Member

ericstj commentedJul 24, 2024•
edited
Loading

@steveharter or@wcsanders1 can you please create a breaking change doc for the new defaults forServiceProviderOptions in development? That will cover the case that we didn't undo here. It can mention that developers can workaround it usingUseDefaultServiceProvider if they don't wish to run validation.

Update - I went ahead and created it, please review what I've created.dotnet/docs#41887

@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsAug 24, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@ericstjericstjericstj left review comments

@benjaminpetitbenjaminpetitAwaiting requested review from benjaminpetit

@halter73halter73Awaiting requested review from halter73

+1 more reviewer

@steveharterstevehartersteveharter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-Extensions-Hostingbreaking-changeIssue or PR that represents a breaking API or functional change over a previous release.needs-breaking-change-doc-createdBreaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wcsanders1@buyaa-n@ericstj@steveharter
[8]ページ先頭
©2009-2025 Movatter.jp