NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Derive OrderedEnumerable from Iterator#98874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stephentoub merged 2 commits intodotnet:mainfromstephentoub:orderedenumerableiterator

Feb 24, 2024

Merged

Derive OrderedEnumerable from Iterator#98874

stephentoub merged 2 commits intodotnet:mainfromstephentoub:orderedenumerableiterator

Feb 24, 2024

Conversation

Copy link

Member

stephentoub commentedFeb 23, 2024

The OrderedEnumerable implementation today doesn't derive from Iterator, and it has a GetEnumerator method implemented with yield. That means the optimization that allows the enumerable to be reused as the enumerator doesn't kick in, and we end up allocating a separate enumerator object in order to iterate through an Order{By} enumerable.

Method	Toolchain	Length	Mean	Ratio	Allocated	Alloc Ratio
Order	\main\corerun.exe	2	51.61 ns	1.00	112 B	1.00
Order	\pr\corerun.exe	2	46.16 ns	0.90	88 B	0.79

OrderBy	\main\corerun.exe	2	86.11 ns	1.00	328 B	1.00
OrderBy	\pr\corerun.exe	2	87.89 ns	1.02	304 B	0.93

Order	\main\corerun.exe	100	652.72 ns	1.00	504 B	1.00
Order	\pr\corerun.exe	100	580.34 ns	0.89	480 B	0.95

OrderBy	\main\corerun.exe	100	1,982.54 ns	1.00	1504 B	1.00
OrderBy	\pr\corerun.exe	100	1,989.22 ns	1.00	1480 B	0.98

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Tests).Assembly).Run(args);[MemoryDiagnoser(false)][HideColumns("Job","Error","StdDev","Median","RatioSD")]publicpartialclassTests{privateint[]_ints;privatePerson[]_people;[Params(2,100)]publicintLength{get;set;}[GlobalSetup]publicvoidSetup(){_ints=Enumerable.Range(0,Length).Reverse().ToArray();_people=_ints.Select(i=>newPerson{Age=i}).ToArray();}[Benchmark]publicintOrder(){intsum=0;foreach(intiin_ints.Order())sum+=i;returnsum;}[Benchmark]publicintOrderBy(){intsum=0;foreach(Personpin_people.OrderBy(p=>p.Age))sum+=p.Age;returnsum;}publicstructPerson{publicintAge{get;set;}}}

stephentoub added2 commits

February 23, 2024 16:34

Move OrderedEnumerable to be nested in Enumerable

ef7cc36

Derive OrderedEnumerable from Iterator

4e350d9

The OrderedEnumerable implementation today doesn't derive from Iterator, and it has a GetEnumerator method implemented with yield. That means the optimization that allows the enumerable to be reused as the enumerator doesn't kick in, and we end up allocating a separate enumerator object in order to iterate through an Order{By} enumerable.

stephentoub added the area-System.Linq label

Feb 23, 2024

stephentoub added this to the9.0.0 milestone

Feb 23, 2024

Copy link

ghost commentedFeb 23, 2024

Tagging subscribers to this area: @dotnet/area-system-linq
See info inarea-owners.md if you want to be subscribed.

Issue Details

Method	Toolchain	Length	Mean	Ratio	Allocated	Alloc Ratio
Order	\main\corerun.exe	2	51.61 ns	1.00	112 B	1.00
Order	\pr\corerun.exe	2	46.16 ns	0.90	88 B	0.79

OrderBy	\main\corerun.exe	2	86.11 ns	1.00	328 B	1.00
OrderBy	\pr\corerun.exe	2	87.89 ns	1.02	304 B	0.93

Order	\main\corerun.exe	100	652.72 ns	1.00	504 B	1.00
Order	\pr\corerun.exe	100	580.34 ns	0.89	480 B	0.95

OrderBy	\main\corerun.exe	100	1,982.54 ns	1.00	1504 B	1.00
OrderBy	\pr\corerun.exe	100	1,989.22 ns	1.00	1480 B	0.98

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;BenchmarkSwitcher.FromAssembly(typeof(Tests).Assembly).Run(args);[MemoryDiagnoser(false)][HideColumns("Job","Error","StdDev","Median","RatioSD")]publicpartialclassTests{privateint[]_ints;privatePerson[]_people;[Params(2,100)]publicintLength{get;set;}[GlobalSetup]publicvoidSetup(){_ints=Enumerable.Range(0,Length).Reverse().ToArray();_people=_ints.Select(i=>newPerson{Age=i}).ToArray();}[Benchmark]publicintOrder(){intsum=0;foreach(intiin_ints.Order())sum+=i;returnsum;}[Benchmark]publicintOrderBy(){intsum=0;foreach(Personpin_people.OrderBy(p=>p.Age))sum+=p.Age;returnsum;}publicstructPerson{publicintAge{get;set;}}}