NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

[mono] Intrinsify multiple StoreVector API's#98514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jkurdek merged 6 commits intodotnet:mainfromjkurdek:vector-store-intrins

Feb 16, 2024

Merged

[mono] Intrinsify multiple StoreVector API's#98514

jkurdek merged 6 commits intodotnet:mainfromjkurdek:vector-store-intrins

Feb 16, 2024

Conversation

Copy link

Contributor

jkurdek commentedFeb 15, 2024•
edited
Loading

Contributes to#93081

This PR intrinsifies the following APIs:

AdvSimd.StoreVector64x*
AdvSimd.Arm64.StoreVector128x*
AdvSimd.StoreVector64xAndZip
AdvSimd.Arm64.StoreVector128xAndZip

jkurdek added2 commits

February 13, 2024 22:21

enabled storevector 128/64x* intrinsics and tests

b665ffc

implemented storevector 128/64x* intrinsics

c81ba2c

jkurdek requested review fromkunalspathak andsteveisok

February 15, 2024 19:10

jkurdek self-assigned this

Feb 15, 2024

ghost added area-System.Runtime.Intrinsics new-api-needs-documentation labels

Feb 15, 2024

Copy link

ghost commentedFeb 15, 2024

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

fanyang-mono reviewed

Feb 15, 2024

View reviewed changes

src/mono/mono/mini/simd-intrinsics.c Outdated


		MonoClass*value=mono_class_from_mono_type_internal (fsig->params [1]);

		MonoInst*ins=emit_simd_ins_for_sig (cfg,klass,OP_ARM64_STM,opcode,arg0_type,fsig,args);

Copy link

Member

fanyang-monoFeb 15, 2024•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

You could passvalue as the second argument foremit_simd_ins_for_sig and get rid of the next line. Althoughvalue is kinda generic. Maybe rename it toklass_tuple_var or something else with more information.