NotificationsYou must be signed in to change notification settings
Fork5.1k
Star16.6k

JIT: Use faster unchecked write-barrier for boxed statics#98166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

EgorBo merged 1 commit intodotnet:mainfromEgorBo:more-faster-wb

Feb 9, 2024

Merged

JIT: Use faster unchecked write-barrier for boxed statics#98166

EgorBo merged 1 commit intodotnet:mainfromEgorBo:more-faster-wb

Feb 9, 2024

Conversation

Copy link

Member

EgorBo commentedFeb 8, 2024•
edited
Loading

And a small clean up.

Example:

structMyStruct{publicobjectObj;}staticMyStructboxedStatic;[MethodImpl(MethodImplOptions.NoInlining)]staticvoidTest(stringstr1,stringstr2){// simple way to trigger CSE:boxedStatic.Obj=str1;boxedStatic.Obj=str2;}

Codegen diff forTest:

; Method Prog:Test(System.String,System.String) (FullOpts)G_M57713_IG01:         push     rdi       push     rsi       push     rbx       sub      rsp, 32       mov      rbx, rcx       mov      rsi, rdxG_M57713_IG02:         test     byte  ptr [(reloc 0x7ff8e243b942)], 1      ; global ptr       je       SHORT G_M57713_IG05G_M57713_IG03:         mov      rcx, 0x21A0D401E10      ; box for Prog:boxedStatic       mov      rdi, gword ptr [rcx]       add      rdi, 8       mov      rcx, rdi       mov      rdx, rbx-      call     CORINFO_HELP_CHECKED_ASSIGN_REF+      call     CORINFO_HELP_ASSIGN_REF       mov      rcx, rdi       mov      rdx, rsi-      call     CORINFO_HELP_CHECKED_ASSIGN_REF+      call     CORINFO_HELP_ASSIGN_REF       nop      G_M57713_IG04:         add      rsp, 32       pop      rbx       pop      rsi       pop      rdi       ret      G_M57713_IG05:         mov      rcx, 0x7FF8E243B910       mov      edx, 2       call     CORINFO_HELP_GETSHARED_NONGCSTATIC_BASE       jmp      SHORT G_M57713_IG03; Total bytes of code: 92

Don't use checked wb for boxed statics

63d71d9

ghost assignedEgorBo

Feb 8, 2024

ghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label

Feb 8, 2024

Copy link

ghost commentedFeb 8, 2024

Tagging subscribers to this area:@JulieLeeMSFT,@jakobbotsch
See info inarea-owners.md if you want to be subscribed.

Issue Details

small clean up.

Example:

structMyStruct{publicobjectObj;}staticMyStructboxedStatic;[MethodImpl(MethodImplOptions.NoInlining)]staticvoidTest(stringstr1,stringstr2){boxedStatic.Obj=str1;boxedStatic.Obj=str2;}

Codegen diff forTest:

; Method Prog:Test(System.String,System.String) (FullOpts)G_M57713_IG01:         push     rdi       push     rsi       push     rbx       sub      rsp, 32       mov      rbx, rcx       mov      rsi, rdxG_M57713_IG02:         test     byte  ptr [(reloc 0x7ff8e243b942)], 1      ; global ptr       je       SHORT G_M57713_IG05G_M57713_IG03:         mov      rcx, 0x21A0D401E10      ; box for Prog:boxedStatic       mov      rdi, gword ptr [rcx]       add      rdi, 8       mov      rcx, rdi       mov      rdx, rbx-      call     CORINFO_HELP_CHECKED_ASSIGN_REF+      call     CORINFO_HELP_ASSIGN_REF       mov      rcx, rdi       mov      rdx, rsi-      call     CORINFO_HELP_CHECKED_ASSIGN_REF+      call     CORINFO_HELP_ASSIGN_REF       nop      G_M57713_IG04:         add      rsp, 32       pop      rbx       pop      rsi       pop      rdi       ret      G_M57713_IG05:         mov      rcx, 0x7FF8E243B910       mov      edx, 2       call     CORINFO_HELP_GETSHARED_NONGCSTATIC_BASE       jmp      SHORT G_M57713_IG03; Total bytes of code: 92

Author:	EgorBo
Assignees:	EgorBo
Labels:	`area-CodeGen-coreclr`
Milestone:	-

This was referencedFeb 8, 2024

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed#97049

Closed

System.Net.Security.Tests.SslStreamCertificateContextOcspLinuxTests.RefreshOcspResponse_BeforeExpiration test failure#97779

Closed

Copy link

MemberAuthor

EgorBo commentedFeb 8, 2024

@MihuBot

MihuBot mentioned this pull request

Feb 8, 2024

[X64] [EgorBo] JIT: Use faster unchecked write-barrier for boxed staticsMihuBot/runtime-utils#239

Open

EgorBo marked this pull request as ready for review

February 8, 2024 22:54

MihuBot mentioned this pull request

Feb 8, 2024

[X64] [EgorBo] JIT: Use faster unchecked write-barrier for boxed staticsMihuBot/runtime-utils#240

Open

Copy link

MemberAuthor

EgorBo commentedFeb 9, 2024•
edited
Loading

@AndyAyersMS @kunalspathak (cc @dotnet/jit-contrib) a quick follow up to my previous PR There are only a fewtext diffs after marking boxed static address as unchecked barrier + a small clean up.