- Notifications
You must be signed in to change notification settings - Fork5.1k
Devirtualize more based on whole program analysis#97812
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Whole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered `final`. Add a pass to collect this information and pass it to codegen,It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app.
ghost commentedFeb 1, 2024
Tagging subscribers to this area:@agocke,@MichalStrehovsky,@jkotas Issue DetailsWhole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app. Cc @dotnet/ilc-contrib
|
/azp run runtime-nativeaot-outerloop |
| Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
Whole program view lets us figure out whether a virtual method has been overriden by another method, or whether it can be considered
final. Add a pass to collect this information and pass it to codegen,It kicks in less often than I expected (for linear enough hierarchies or not-too-much-derived types we could already do this with guarded devirtualization or type sealing), but I can still a bit over 100 method bodies affected by this in the Stage1 app.
Cc @dotnet/ilc-contrib