Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove helper frames#97469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@AaronRobinsonMSFT
Copy link
Member

Convert GC function into QCall

Port CustomAttribute data parsing into C#.

PaulusParssinen reacted with thumbs up emojiPaulusParssinen reacted with rocket emoji
@AaronRobinsonMSFT
Copy link
MemberAuthor

/cc@jkotas

@lambdageek
Copy link
Member

How do you avoid chicken-and-egg problems? does this custom attribute parser get used when you are loading some class or JITing a method? What if there was[InlineArray] data inRuntimeCustomAttributeData.cs that the parser itself depended on, for example?

@AaronRobinsonMSFT
Copy link
MemberAuthor

AaronRobinsonMSFT commentedJan 24, 2024
edited
Loading

@lambdageek I didn't remove the parser itself, just the infrastructure around calling the native parser from managed code. This was very old code and the process was rather complicated.

  1. Partially populate, using Reflection, managed types with details for the signature parsing
  2. Pass those managed types down into native via an FCall
  3. Convert the data in the managed types into the native types
  4. Parsing the signature blob using the details in the native types
  5. Place the data from the native types into the managed types
  6. Move back into managed code and lazily convert the raw details into public surface types

This PR simply collapses 2 - 5 and does it all in C#.

lambdageek reacted with thumbs up emoji

The managed Utf8 decoder produces slightly different errors characters
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you!

@AaronRobinsonMSFTAaronRobinsonMSFT merged commit0d81a5a intodotnet:mainJan 26, 2024
@AaronRobinsonMSFTAaronRobinsonMSFT deleted the remove_helper_frames branchJanuary 26, 2024 03:02
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 25, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@lambdageeklambdageeklambdageek left review comments

@stephentoubstephentoubstephentoub left review comments

@jkotasjkotasjkotas approved these changes

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronRobinsonMSFT@lambdageek@stephentoub@jkotas

[8]ページ先頭

©2009-2025 Movatter.jp