NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Adding vectorized implementations of Log to Vector64/128/256/512#96913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

tannergooding merged 5 commits intodotnet:mainfromtannergooding:fix-93513

Jan 17, 2024

Merged

Adding vectorized implementations of Log to Vector64/128/256/512#96913

tannergooding merged 5 commits intodotnet:mainfromtannergooding:fix-93513

Jan 17, 2024

Conversation

Copy link

Member

tannergooding commentedJan 12, 2024

This makes progress towards#93513

tannergooding added2 commits

January 12, 2024 12:15

Adding vectorized implementations of Log to Vector64/128/256/512

57f9d4b

Accelerate TensorPrimitives.Log for double

2961241

ghost assignedtannergooding

Jan 12, 2024

ghost added the area-System.Numerics label

Jan 12, 2024

Copy link

ghost commentedJan 12, 2024

Tagging subscribers to this area: @dotnet/area-system-numerics
See info inarea-owners.md if you want to be subscribed.

Issue Details

This makes progress towards#93513

Author:	tannergooding
Assignees:	tannergooding
Labels:	`area-System.Numerics`
Milestone:	-

tannergooding added2 commits

January 12, 2024 12:40

Ensure the ref assembly is updated to include the new Log method

f16dc65

Fix the variance for one of the Log2 tests to account for the scalar …

4514b8c

…fallback

Copy link

MemberAuthor

tannergooding commentedJan 12, 2024

CC.@stephentoub,@michaelgsharp for review.

Will likely put up separate PRs for a few others over the weekend, likeExp and the rest of the ones already accelerated forfloat inTensorPrimitives

May also finish up several of the trig ones (Cos,Sin,Tan, etc)

This was referencedJan 13, 2024

Test failure - System.NullReferenceException in System.Threading.Lock.TryInitializeStatics#94728

Closed

pip fails to build wheels for cffi (gcc not found) in ubuntu.1804.armarch.open using image alpine-3.15-helix-arm32v7dotnet/dnceng#1423

Closed

Assert failure: orObject->HasEmptySyncBlockInfo()#96790

Closed

CollectionsMarshal.AsSpan assertion failure in System.Text.Json tests#96876

Closed

Merge remote-tracking branch 'dotnet/main' into fix-93513

7304112

Copy link

Member

stephentoub commentedJan 16, 2024

I assume structurally this is a carbon-copy of#93513?

Copy link

MemberAuthor

tannergooding commentedJan 16, 2024

I assume structurally this is a carbon-copy of#93513?

Yes, same general setup/considerations. Just for the Log method now instead of Log2

This was referencedJan 16, 2024

Segmentation fault in System.Text.RegularExpressions.Tests#93206

Closed

Tests crashing in CI with no dump: exit code 137 means SIGKILL Killed#97049

Closed

stephentoub approved these changes

Jan 17, 2024

View reviewed changes

Copy link

MemberAuthor

tannergooding commentedJan 17, 2024

Test failures are known and tracked.

tannergooding merged commit06005da intodotnet:main

Jan 17, 2024

tannergooding deleted the fix-93513 branch

January 17, 2024 16:53

tmds pushed a commit to tmds/runtime that referenced this pull request

Jan 23, 2024

Adding vectorized implementations of Log to Vector64/128/256/512 (dot…

dea509d

…net#96913)* Adding vectorized implementations of Log to Vector64/128/256/512* Accelerate TensorPrimitives.Log for double* Ensure the ref assembly is updated to include the new Log method* Fix the variance for one of the Log2 tests to account for the scalar fallback