Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Remove helperframe marshal#96860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@AaronRobinsonMSFT
Copy link
Member

ConvertMarshal API FCalls withHelperMethodFrames into QCalls.

PaulusParssinen reacted with rocket emoji
Convert Marshal.GetHRForException and Marshal.GetExceptionForHRInternal to QCalls.
Copy link
Member

@davidwrightondavidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

OffsetOfInternal shouldn't take a field object, it should just be implemented as taking a FieldDesc* as input. Then it won't need anything to do with wonking around with the GC state at all, and can operate entirely in preemptive mode

arezooalizadeh06 reacted with thumbs up emoji
@ghostghost added the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJan 11, 2024
@ghostghost removed the needs-author-actionAn issue or pull request that requires more info or actions from the author. labelJan 11, 2024
@AaronRobinsonMSFT
Copy link
MemberAuthor

OffsetOfInternal shouldn't take a field object, it should just be implemented as taking a FieldDesc* as input. Then it won't need anything to do with wonking around with the GC state at all, and can operate entirely in preemptive mode

@davidwrighton Done.

Copy link
Member

@davidwrightondavidwrighton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just one more nit... around unnecessary GCX_PREEMP();

AaronRobinsonMSFT reacted with thumbs up emoji
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM. Thanks!

tmds pushed a commit to tmds/runtime that referenced this pull requestJan 23, 2024
* Remove HelperMethodFrames from Marshal APIsConvert Marshal.GetHRForException and Marshal.GetExceptionForHRInternal to QCalls.* Convert OffsetOfHelper to QCall* Feedback* Remove GC transition.* Update src/coreclr/System.Private.CoreLib/src/System/Runtime/InteropServices/Marshal.CoreCLR.cs* Update src/coreclr/vm/marshalnative.cpp---------Co-authored-by: Jan Kotas <jkotas@microsoft.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 11, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@jkotasjkotasjkotas approved these changes

@davidwrightondavidwrightondavidwrighton approved these changes

@elinor-fungelinor-fungelinor-fung approved these changes

Projects

None yet

Milestone

9.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@AaronRobinsonMSFT@jkotas@davidwrighton@elinor-fung
[8]ページ先頭
©2009-2025 Movatter.jp