- Notifications
You must be signed in to change notification settings - Fork5.2k
Update riscv64 image to clang17#96827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedJan 11, 2024
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries Issue DetailsCurrent version: clang15 Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.
|
ghost commentedJan 11, 2024
Tagging subscribers to this area: @dotnet/runtime-infrastructure Issue DetailsCurrent version: clang15 Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.
|
am11 commentedJan 11, 2024
riscv64 picked up clang 17. -- The C compiler identification is Clang 17.0.6-- The CXX compiler identification is Clang 17.0.6-- Detecting C compiler ABI info-- Detecting C compiler ABI info -done-- Checkfor working C compiler: /usr/bin/clang-17 - skipped-- Detecting C compile features-- Detecting C compile features -done-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info -done-- Checkfor working CXX compiler: /usr/bin/clang++-17 - skipped-- Detecting CXX compile features-- Detecting CXX compile features -doneDetected Linux riscv64 |
akoeplinger commentedJan 11, 2024
Sounds good, but we don't need to merge the PR since the floating tag will get updated. |
am11 commentedJan 11, 2024
ah, I thought the production ones take longer:https://github.com/dotnet/versions/commits/main/build-info/docker/image-info.dotnet-dotnet-buildtools-prereqs-docker-production.json, but apparently staging also push the floating tags (so what's the difference 🤷). It was picked up in main via floating tag. So Closing. :) |
akoeplinger commentedJan 12, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah looks like the -production.json is no longer used, it wasn't updated for almost a year. I've asked for clarification indotnet/dotnet-buildtools-prereqs-docker#956 |
Current version: clang15
New version: clang17
Since risc-v is relatively a new architecture and toolchains are still in the process of implementing new extensions and optimizations overall, we should prefer the latest version for CI build validations.