Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

PlaceInterfaceMethod is now more optimized#96703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

davidwrighton
Copy link
Member

  • It naturally has an O(NM) algorithm, we reduce it to O(N(Msmaller)), and make the constant factor faster
  • We take a local copy of the declared methods and name hashes, and the scan is now a straight linear scan of 32 bit memory DWORDS, and naturally skips nonpublic and non virtual methods.

- It naturally has an O(N*M) algorithm, we reduce it to O(N*(Msmaller)), and make the constant factor faster- We take a local copy of the declared methods and name hashes, and the scan is now a straight linear scan of 32 bit memory DWORDS, and naturally skips nonpublic and non virtual methods.
Copy link
Member

@jkotasjkotas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM!

@davidwrightondavidwrighton merged commit904c439 intodotnet:mainJan 10, 2024
@davidwrightondavidwrighton deleted the FasterPlaceInterfaceMethods branchJanuary 10, 2024 18:27
tmds pushed a commit to tmds/runtime that referenced this pull requestJan 23, 2024
* PlaceInterfaceMethod is now more optimized- It naturally has an O(N*M) algorithm, we reduce it to O(N*(Msmaller)), and make the constant factor faster- We take a local copy of the declared methods and name hashes, and the scan is now a straight linear scan of 32 bit memory DWORDS, and naturally skips nonpublic and non virtual methods.---------Co-authored-by: Aaron Robinson <arobins@microsoft.com>
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 10, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@jkotasjkotasjkotas approved these changes

@AaronRobinsonMSFTAaronRobinsonMSFTAaronRobinsonMSFT approved these changes

Assignees

@davidwrightondavidwrighton

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@davidwrighton@jkotas@AaronRobinsonMSFT
[8]ページ先頭
©2009-2025 Movatter.jp