Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[wasm] Browser.targets: Fix .dlls being deployed topublish/#96045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
radical merged 4 commits intodotnet:mainfromradical:fix-blazor-publish
Dec 19, 2023

Conversation

@radical
Copy link
Member

@radicalradical commentedDec 15, 2023
edited
Loading

IL-linked dlls get copied to thepublish/ directory when using AOT. This is because inProcessPublishFilesForWasm target theResolvedFileToPublish item ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.

@ghostghost added the area-Build-mono labelDec 15, 2023
@ghostghost assignedradicalDec 15, 2023
IL-linked dlls get copied to the `publish/` directory when using AOT.This is because in `ProcessPublishFilesForWasm` target the`ResolvedFileToPublish` item ends with a copy of the original .dllfiles, even though they should be replaced with what was received fromthe nested publish.
@radicalradical marked this pull request as ready for reviewDecember 19, 2023 01:24
@radicalradical added the arch-wasmWebAssembly architecture labelDec 19, 2023
@ghost
Copy link

Tagging subscribers to 'arch-wasm':@lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

IL-linked dlls get copied to thepublish/ directory when using AOT. This is because inProcessPublishFilesForWasm target theResolvedFileToPublish item ends with a copy of the original .dll files, even though they should be replaced with what was received from the nested publish.

Author:radical
Assignees:radical
Labels:

arch-wasm,area-Build-mono

Milestone:-

Copy link
Member

@marafmaraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me 👍

@radicalradical merged commitd425183 intodotnet:mainDec 19, 2023
@radekdoulik
Copy link
Member

this improved the size a lot :-)

image

should it be back ported to NET8 or was the issue present only in the main?

@radicalradical deleted the fix-blazor-publish branchJanuary 4, 2024 17:53
@github-actionsgithub-actionsbot locked and limited conversation to collaboratorsFeb 4, 2024
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@marafmarafmaraf approved these changes

@ilonatommyilonatommyilonatommy approved these changes

@pavelsavarapavelsavaraAwaiting requested review from pavelsavara

@lewinglewingAwaiting requested review from lewinglewing is a code owner

Assignees

@radicalradical

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@radical@radekdoulik@maraf@ilonatommy

[8]ページ先頭

©2009-2025 Movatter.jp