NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

[wasm] Bump chrome for testing - linux: 120.0.6099.71, windows: 120.0.6099.71#95832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

radical merged 2 commits intomainfromupdate-chrome-version-7154287706

Dec 13, 2023

Merged

[wasm] Bump chrome for testing - linux: 120.0.6099.71, windows: 120.0.6099.71#95832

radical merged 2 commits intomainfromupdate-chrome-version-7154287706

Dec 13, 2023

Conversation

Copy link

Contributor

github-actionsbot commentedDec 10, 2023

No description provided.

Automated bump of chrome version

6965f3b

github-actionsbot added arch-wasm

WebAssembly architecture

area-Infrastructure-mono labels

Dec 10, 2023

github-actionsbot requested review fromilonatommy,lewing,maraf,pavelsavara andradical

December 10, 2023 00:06

Copy link

ghost commentedDec 10, 2023

Tagging subscribers to 'arch-wasm':@lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author:	github-actions[bot]
Assignees:	-
Labels:	`arch-wasm`,`area-Infrastructure-mono`
Milestone:	-

This was referencedDec 10, 2023

[wasm][debugger] Debugger tests disabled#89409

Open

The active test run was aborted. Reason: Test host process crasheddotnet/dnceng#451

Closed

radical approved these changes

Dec 11, 2023

View reviewed changes

Copy link

Member

radical commentedDec 11, 2023

Cc@thaystg @ilonatommy debugger test failures

Copy link

Member

ilonatommy commentedDec 11, 2023•
edited by radical
Loading

It seems objectId changed format. Now the test is sendingRuntime.callFunctionOn with
args=

{"functionDeclaration":"function(){const e={__proto__:this.__proto__},t=Object.getOwnPropertyNames(this);for(let r=0;r<t.length;++r){const n=t[r],i=n>>>0;if(String(i>>>0)===n&&i>>>0!=4294967295)continue;const a=Object.getOwnPropertyDescriptor(this,n);a&&Object.defineProperty(e,n,a)}return e}","objectId":"7794664587706423672.1.8"}

soobjectId=7794664587706423672.1.8. It should not be a hard fix.

edit: they can be negative as well, another example:-431145733616042063.1.8

Copy link

Member

radical commentedDec 11, 2023

soobjectId=7794664587706423672.1.8. It should not be a hard fix.
edit: they can be negative as well, another example:-431145733616042063.1.8

That sounds like some error/failure caused this weird id?

Copy link

Member

ilonatommy commentedDec 12, 2023

It's not an error, the quoted structure comes fromvar pause_location = await insp.WaitFor(Inspector.PAUSE);
We are breakpointing in JS code, so Proxy is only passing the message from chrome, without modifications. The message contains this new IDs:

{  "callFrames": [    {      "callFrameId": "6735255319753501795.1.0",      "functionName": "big_array_js_test",      "functionLocation": {        "scriptId": "5",        "lineNumber": 5,        "columnNumber": 27      },      "location": {        "scriptId": "5",        "lineNumber": 10,        "columnNumber": 1      },      "url": "",      "scopeChain": [        {          "type": "local",          "object": {            "type": "object",            "className": "Object",            "description": "Object",            "objectId": "6735255319753501795.1.3"          },          "name": "big_array_js_test",          "startLocation": {            "scriptId": "5",            "lineNumber": 5,            "columnNumber": 27          },          "endLocation": {            "scriptId": "5",            "lineNumber": 11,            "columnNumber": 1          }        },        {          "type": "global",          "object": {            "type": "object",            "className": "Window",            "description": "Window",            "objectId": "6735255319753501795.1.4"          }        }      ],      "this": {        "type": "undefined"      },      "canBeRestarted": true    },    {      "callFrameId": "6735255319753501795.1.1",      "functionName": "",      "functionLocation": {        "scriptId": "238",        "lineNumber": 0,        "columnNumber": 26      },      "location": {        "scriptId": "238",        "lineNumber": 0,        "columnNumber": 31      },      "url": "",      "scopeChain": [        {          "type": "local",          "object": {            "type": "object",            "className": "Object",            "description": "Object",            "objectId": "6735255319753501795.1.5"          },          "startLocation": {            "scriptId": "238",            "lineNumber": 0,            "columnNumber": 26          },          "endLocation": {            "scriptId": "238",            "lineNumber": 0,            "columnNumber": 56          }        },        {          "type": "global",          "object": {            "type": "object",            "className": "Window",            "description": "Window",            "objectId": "6735255319753501795.1.6"          }        }      ],      "this": {        "type": "object",        "className": "Window",        "description": "Window",        "objectId": "6735255319753501795.1.7"      },      "canBeRestarted": true    }  ],  "reason": "other",  "hitBreakpoints": [    "1:10:1:http://localhost:9400/other.js"  ],  "asyncStackTrace": {    "description": "setTimeout",    "callFrames": [      {        "functionName": "",        "scriptId": "238",        "url": "",        "lineNumber": 0,        "columnNumber": 7      }    ]  },  "sessionId": null}

We can fix it and keep fixing it each time the protocol changes on next updates.