- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/7.0] fix div by zero in gen size calculation#76334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedSep 28, 2022
Tagging subscribers to this area: @dotnet/gc Issue DetailsBackport of#76294 to release/7.0 /cc@Maoni0 Customer ImpactTestingRiskIMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessarypackage authoring and gotten it explicitly reviewed.
|
carlossanlop commentedSep 28, 2022
@Maoni0 if this is ready, can you please add the |
carlossanlop commentedSep 29, 2022
Approved by Tactics via email. Signed off. |
Uh oh!
There was an error while loading.Please reload this page.
Backport of#76294 to release/7.0
/cc@Maoni0
Customer Impact
This was reported with#76257. It's a bug that only shows up with regions. With segments, because we always allocate a min object in each generation to indicate the generation start, the size can never be 0. With regions we no long need to but this also means a generation size can be 0. The workaround is unacceptable to the customer -
Testing
I tested this under the debugger. I can see the div zero exception and with the fix I no longer see it.
Risk
Not for a servicing release.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessarypackage authoring and gotten it explicitly reviewed.