Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[release/7.0] fix div by zero in gen size calculation#76334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
carlossanlop merged 1 commit intorelease/7.0frombackport/pr-76294-to-release/7.0
Sep 29, 2022

Conversation

@github-actions
Copy link
Contributor

@github-actionsgithub-actionsbot commentedSep 28, 2022
edited by Maoni0
Loading

Backport of#76294 to release/7.0

/cc@Maoni0

Customer Impact

This was reported with#76257. It's a bug that only shows up with regions. With segments, because we always allocate a min object in each generation to indicate the generation start, the size can never be 0. With regions we no long need to but this also means a generation size can be 0. The workaround is unacceptable to the customer -

it is not easy to disable floating point exception around garbage collector because it may be called everywhere. Net 6 and older versions (and the mono runtime) don't need such a workaround. In the HPC world it is a common practice to trap FPE to detect false numerical results. I agree that some .Net libraries may not support that but if the runtime doesn't have this new limitation it is better.

Testing

I tested this under the debugger. I can see the div zero exception and with the fix I no longer see it.

Risk

Not for a servicing release.

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessarypackage authoring and gotten it explicitly reviewed.

@ghostghost added the area-GC-coreclr labelSep 28, 2022
@ghost
Copy link

Tagging subscribers to this area: @dotnet/gc
See info inarea-owners.md if you want to be subscribed.

Issue Details

Backport of#76294 to release/7.0

/cc@Maoni0

Customer Impact

Testing

Risk

IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessarypackage authoring and gotten it explicitly reviewed.

Author:github-actions[bot]
Assignees:-
Labels:

area-GC-coreclr

Milestone:-

@carlossanlop
Copy link
Contributor

@Maoni0 if this is ready, can you please add theservicing-consider label and send an email to Tactics requesting approval?

@Maoni0Maoni0 added the Servicing-considerIssue for next servicing release review labelSep 28, 2022
@carlossanlopcarlossanlop added Servicing-approvedApproved for servicing release and removed Servicing-considerIssue for next servicing release review labelsSep 29, 2022
@carlossanlop
Copy link
Contributor

Approved by Tactics via email. Signed off.
CI failure was a timeout cancellation in OSX NativeAOT.
Ready to merge.:shipit:

@carlossanlopcarlossanlop merged commit9930d32 intorelease/7.0Sep 29, 2022
@carlossanlopcarlossanlop deleted the backport/pr-76294-to-release/7.0 branchSeptember 29, 2022 00:58
@carlossanlopcarlossanlop added this to the7.0.0 milestoneSep 29, 2022
@ghostghost locked asresolvedand limited conversation to collaboratorsOct 29, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@mangod9mangod9mangod9 approved these changes

Assignees

No one assigned

Labels

area-GC-coreclrServicing-approvedApproved for servicing release

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@carlossanlop@mangod9@Maoni0

[8]ページ先頭

©2009-2025 Movatter.jp