Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add CertificateRevocationListBuilder#72708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bartonjs merged 5 commits intodotnet:mainfrombartonjs:crlbuilder
Jul 26, 2022
Merged

Conversation

bartonjs
Copy link
Member

This adds CRLBuilder, without the static method to create a CDP extension.

It still needs a lot of tests (ccov is only at 55% and Load is entirely untested), but throwing up a draft for any interested early eyeballs.

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-security,@vcsjones
See info inarea-owners.md if you want to be subscribed.

Issue Details

This adds CRLBuilder, without the static method to create a CDP extension.

It still needs a lot of tests (ccov is only at 55% and Load is entirely untested), but throwing up a draft for any interested early eyeballs.

Author:bartonjs
Assignees:bartonjs
Labels:

area-System.Security,cryptographic-docs-impact

Milestone:7.0.0

@vcsjonesvcsjones self-requested a reviewJuly 23, 2022 00:28
Copy link
Member

@vcsjonesvcsjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Didn't comment on tests since those are in-flight.

@bartonjsbartonjs marked this pull request as ready for reviewJuly 25, 2022 23:18
Copy link
Member

@vcsjonesvcsjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good to me, just some small questions.

@bartonjsbartonjs merged commitedb30e7 intodotnet:mainJul 26, 2022
@bartonjsbartonjs deleted the crlbuilder branchJuly 26, 2022 16:37
@bartonjsbartonjs added the needs-further-triageIssue has been initially triaged, but needs deeper consideration or reconsideration labelAug 19, 2022
@ghostghost locked asresolvedand limited conversation to collaboratorsSep 19, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@vcsjonesvcsjonesvcsjones approved these changes

Assignees

@bartonjsbartonjs

Labels
area-System.Securityneeds-further-triageIssue has been initially triaged, but needs deeper consideration or reconsiderationnew-api-needs-documentation
Projects
None yet
Milestone
7.0.0
Development

Successfully merging this pull request may close these issues.

2 participants
@bartonjs@vcsjones
[8]ページ先頭
©2009-2025 Movatter.jp