- Notifications
You must be signed in to change notification settings - Fork5.1k
Use u8 in a few more places#70568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedJun 10, 2022
Tagging subscribers to this area: @dotnet/area-meta Issue Detailsnull
|
| (byte)'i', (byte)'j', (byte)'k', (byte)'l', (byte)'m', (byte)'n', (byte)'o', (byte)'p', | ||
| (byte)'q', (byte)'r', (byte)'s', (byte)'t', (byte)'u', (byte)'v', (byte)'w', (byte)'x', | ||
| (byte)'y', (byte)'z', (byte)'0', (byte)'1', (byte)'2', (byte)'3', (byte)'4', (byte)'5' }; | ||
| private static ReadOnlySpan<byte> Base32Char => "abcdefghijklmnopqrstuvwxyz012345"u8; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
ended up looking at Populate83FileNameFromRandomBytes. do you know why it's taking bits of the random bytes in such a peculiarly special way? why doesn't it just take as many bytes as it needs, skip any beyond a multiple of the length of this array, and just modulo over this array? perhaps because random bytes gotten this way are expensive?
src/libraries/System.Reflection.Metadata/src/System/Reflection/Metadata/MetadataReader.WinMD.csShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
No description provided.