Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use stack buffers and return data to pool in EC point encoding#69812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bartonjs merged 1 commit intodotnet:mainfromvcsjones:fix-pool-return
May 25, 2022

Conversation

vcsjones
Copy link
Member

@vcsjonesvcsjones commentedMay 25, 2022•
edited
Loading

This all started becauseWriteUncompressedPublicKey was renting fromCryptoPool and never returning the rented buffer. So I fixed that. But oh, wait, these buffers fit pretty comfortably in the stack, so let's do that while we're here.

@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-security,@vcsjones
See info inarea-owners.md if you want to be subscribed.

Issue Details

This all started becauseWriteUncompressedPublicKey was renting fromCryptoPool and never returning. So I fixed that. But oh, wait, these buffers fit pretty comfortably in the stack, so let's do that while we're here.

Author:vcsjones
Assignees:vcsjones
Labels:

area-System.Security

Milestone:-

@vcsjones
Copy link
MemberAuthor

I'm super confused by CI. It appears to be running jitstress and outer loop for some reason.

@bartonjs
Copy link
Member

#69813 sees the same failures launching the Quic tests, and everything seems to be launching jitstress and outerloop with no access token... so... merging.

@bartonjsbartonjs merged commit032a7dc intodotnet:mainMay 25, 2022
@vcsjonesvcsjones deleted the fix-pool-return branchMay 25, 2022 22:17
@ghostghost locked asresolvedand limited conversation to collaboratorsJun 25, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@bartonjsbartonjsbartonjs approved these changes

Assignees

@vcsjonesvcsjones

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@vcsjones@bartonjs
[8]ページ先頭
©2009-2025 Movatter.jp