Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Expose the GetShortestBitLength, GetByteCount, and WriteLittleEndian APIs#67939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tannergooding merged 2 commits intodotnet:mainfromtannergooding:generic-math
Apr 15, 2022

Conversation

tannergooding
Copy link
Member

@tannergoodingtannergooding commentedApr 13, 2022
edited
Loading

Still pending are the equivalent APIs for getting the exponent/significand for floating-point numbers and the Create* API changes, will be in follow up PRs to help keep size down

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly onearea label.

@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-numerics
See info inarea-owners.md if you want to be subscribed.

Issue Details

null

Author:tannergooding
Assignees:tannergooding
Labels:

area-System.Numerics,new-api-needs-documentation

Milestone:-

@tannergooding
Copy link
MemberAuthor

CC.@lewing@BrzVlad

This is triggering a mono-runtime assert for wasm and impacts the generic math API surface we want to preview at build.

Copy link
Contributor

@dakersnardakersnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good!

@tannergooding
Copy link
MemberAuthor

Worked around some test failures (and logged corresponding issues). Also fixed an error where these APIs shouldn't be on float/double/decimal/Half. The floating-point types are getting separate APIs to get the exponent and significand instead, so that the value can be understood.

@tannergoodingtannergooding added the NO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons) labelApr 14, 2022
@tannergoodingtannergoodingforce-pushed thegeneric-math branch 3 times, most recently fromd5942ee to5077eb9CompareApril 14, 2022 06:36
@tannergooding
Copy link
MemberAuthor

No changes, just squashed commits together and rebased ontop of#68043 now that it's merged.

This is now "just" theGetShortestBitLength,GetByteCount, andWriteLittleEndian APIs + relevant tests and doesn't include the WASM disablement since#67999 repros even with them disabled

@tannergooding
Copy link
MemberAuthor

Merge with main to pickup#68058

@tannergoodingtannergooding merged commitc01a512 intodotnet:mainApr 15, 2022
@tannergoodingtannergooding removed the NO-MERGEThe PR is not ready for merge yet (see discussion for detailed reasons) labelApr 15, 2022
@ghostghost locked asresolvedand limited conversation to collaboratorsMay 15, 2022
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Reviewers

@stephentoubstephentoubstephentoub approved these changes

@dakersnardakersnardakersnar approved these changes

Assignees

@tannergoodingtannergooding

Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@tannergooding@stephentoub@dakersnar

[8]ページ先頭

©2009-2025 Movatter.jp