- Notifications
You must be signed in to change notification settings - Fork5.1k
Faster IndexOf for arm64#67811
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Faster IndexOf for arm64#67811
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedApr 9, 2022
Tagging subscribers to this area: @dotnet/area-system-memory Issue DetailsUse a slightly faster "no matches" check in Benchmark: publicclassBenchmarks{publicIEnumerable<object[]>TestData(){// Small inputs which are handled via SIMDyieldreturnnewobject[]{"12345678",'1'};yieldreturnnewobject[]{"123456789",'9'};yieldreturnnewobject[]{"1234567812345678",'1'};yieldreturnnewobject[]{"1234567812345678",'0'};yieldreturnnewobject[]{"Console WriteLine Hello World",'o'};yieldreturnnewobject[]{"Console WriteLine Hello World",'d'};// Large inputsyieldreturnnewobject[]{newstring('x',64),'y'};yieldreturnnewobject[]{newstring('x',200),'y'};yieldreturnnewobject[]{newstring('x',1000),'y'};yieldreturnnewobject[]{newstring('x',1000000),'y'};}[Benchmark][ArgumentsSource(nameof(TestData))]publicintIndexOf_byte(stringstr,charc){returnMemoryMarshal.Cast<char,byte>(str.AsSpan()).IndexOf((byte)c);}[Benchmark][ArgumentsSource(nameof(TestData))]publicintIndexOf_char(stringstr,charc){returnstr.AsSpan().IndexOf(c);}} IndexOf_byteIndexOf_charup +40% faster for large inputs can 0.5-1ns regress in the worst case - if input is found in the very first vector.
|
kunalspathak approved these changesApr 11, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM
Performance improvement on Windows arm64:dotnet/perf-autofiling-issues#4732 |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Use a slightly faster "no matches" check in
IndexOfandIndexOfAny.Benchmark:
IndexOf_byte
IndexOf_char
up to +40% faster for large inputs can 0.5-1ns regress in the worst case - if input is found in the very first vector.
There are weird regressions
but it goes away in FullPGO mode (and the PR becomes faster than the base as expected in this case) - it means the loop is not properly aligned by default. So the regression will be fixed once we update *.mibc for corelib (IndexOf definitely participates in the trainings)