- Notifications
You must be signed in to change notification settings - Fork5.1k
JIT: Faster vector == Vector128.Zero on arm64#65632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ghost commentedFeb 20, 2022
Tagging subscribers to this area:@JulieLeeMSFT Issue DetailsCloses#63829 staticboolIsZero(Vector128<int>vec)=>vec==Vector128<int>.Zero; Codegen diff: ; Assembly listing for method IsZero(System.Runtime.Intrinsics.Vector128`1[Int32]):bool stp fp, lr, [sp,#-16]! mov fp, sp- cmeq v16.4s, v0.4s, #0- uminv b16, v16.16b+ umaxv b16, v0.16b umov w0, v16.b[0] cmp w0, #0- cset x0, ne+ cset x0, eq ldp fp, lr, [sp],#16 ret lr-; Total bytes of code 36+; Total bytes of code 32 This is needed for faster IndexOf from#63285. Also,#65288 relies on it. Perf_Regex_Industry_RustLang_SherlockBenchmark:
|
PTAL @echesakovMSFT@TIHan |
cc@vargaz@fanyang-mono the Test I added in this PR crashes on |
This will fix it: |
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
TIHan approved these changesFeb 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Looks good! Only a few comments.
Member
fanyang-mono commentedFeb 22, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
I had created an issue to clean up the code for type checks of vector elements. Haven't get to it yet. (#65318) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Left some comments
Uh oh!
There was an error while loading.Please reload this page.
src/coreclr/jit/lowerarmarch.cpp Outdated
| if (!varTypeIsFloating(simdBaseType) && (op != nullptr)) | ||
| { | ||
| GenTree* cmp = | ||
| comp->gtNewSimdHWIntrinsicNode(simdType, op, NI_AdvSimd_Arm64_MaxAcross, CORINFO_TYPE_UBYTE, simdSize); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
According toArm® Cortex®-A76 Software Optimization Guide:UMAXV, 16B has Exec latency6 and Execution throughput1/2
whileUMAXV, 4H/4S has Exec latency3 and Execution throughput1
Do we wantCORINFO_TYPE_USHORT/CORINFO_TYPE_UINT as a base type instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, let's change, Although, I had this in mind when I was benchmarking it and saw zero difference, but I now I see why:
(Apple M1, Firestorm core)
echesakov approved these changesFeb 22, 2022
This was referencedFeb 23, 2022
Contributor
kunalspathak commentedMar 3, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Improvements indotnet/perf-autofiling-issues#3833 anddotnet/perf-autofiling-issues#3829 |
wow, it's more than I expected |
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Closes#63829
Codegen diff:
This is needed for faster IndexOf from#63285. Also,#65288 relies on it.
Perf_Regex_Industry_RustLang_SherlockBenchmark:
Diffs