Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add Capture.ValueSpan#57357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stephentoub merged 1 commit intodotnet:mainfromstephentoub:capturevaluespan
Aug 13, 2021
Merged

Conversation

@stephentoub
Copy link
Member

Based on offline discussion with area owners and API review.
Contributes to#23602

@ghost
Copy link

Tagging subscribers to this area:@eerhardt, @dotnet/area-system-text-regularexpressions
See info inarea-owners.md if you want to be subscribed.

Issue Details

Based on offline discussion with area owners and API review.
Contributes to#23602

Author:stephentoub
Assignees:-
Labels:

area-System.Text.RegularExpressions

Milestone:6.0.0

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

Copy link
Member

@GrabYourPitchforksGrabYourPitchforks left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for improving the tests as well!

Nit: The test .csproj file somehow got a UTF-8 BOM appended. Consider re-saving this file as "UTF-8 without BOM".

Edit: I think I looked at the diff backward and that your PR actuallyremoves the BOM. Hooray! 🎉

stephentoub reacted with thumbs up emoji
@electricessence
Copy link

electricessence commentedAug 13, 2021•
edited
Loading

@stephentoub Thanks for starting this!
I'm guessing this isn't gonna be public for a while?
.NET 6?

@stephentoubstephentoub merged commit7898f9b intodotnet:mainAug 13, 2021
@stephentoubstephentoub deleted the capturevaluespan branchAugust 13, 2021 22:58
@stephentoub
Copy link
MemberAuthor

.NET 6?

Yes

@ghostghost locked asresolvedand limited conversation to collaboratorsSep 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@GrabYourPitchforksGrabYourPitchforksGrabYourPitchforks approved these changes

@danmoseleydanmoseleydanmoseley approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

4 participants

@stephentoub@electricessence@GrabYourPitchforks@danmoseley
[8]ページ先頭
©2009-2025 Movatter.jp