Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Enable FileStream length caching with FileShare.Delete#56465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
2 commits merged intodotnet:mainfrompentp:fs-length-caching
Jul 29, 2021

Conversation

@pentp
Copy link
Contributor

FileShare.Delete doesn't allow file length to change.
Also cleaned up theshare parameter from handle based strategy constructors.

@ghostghost added community-contributionIndicates that the PR has been added by a community member area-System.IO and removed community-contributionIndicates that the PR has been added by a community member labelsJul 28, 2021
@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-io
See info inarea-owners.md if you want to be subscribed.

Issue Details

FileShare.Delete doesn't allow file length to change.
Also cleaned up theshare parameter from handle based strategy constructors.

Author:pentp
Assignees:-
Labels:

area-System.IO

Milestone:-

@stephentoub
Copy link
Member

Enable FileStream length caching with FileShare.Delete

I must be missing it, but I don't see any changes related to FileShare.Delete...?

@pentp
Copy link
ContributorAuthor

Previously the check was_share <= FileShare.Read, now it's(share & FileShare.Write) == 0 so it allows length caching ifFileShare.Read | FileShare.Delete is used to open a file.

adamsitnik reacted with thumbs up emoji

Copy link
Member

@adamsitnikadamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Overall LGTM, but it would be great to rename the field before we hit the merge button.

@pentp thank you!

@pentppentp requested a review fromadamsitnikJuly 29, 2021 17:26
Copy link
Member

@adamsitnikadamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thank you@pentp !

@adamsitnikadamsitnik added this to the6.0.0 milestoneJul 29, 2021
@ghost
Copy link

Hello@adamsitnik!

Because this pull request has theauto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn morehere.

@adamsitnikadamsitnik added the tenet-performancePerformance related issue labelJul 29, 2021
@ghost ghost merged commit61335ca intodotnet:mainJul 29, 2021
@pentppentp deleted the fs-length-caching branchJuly 30, 2021 13:01
@ghostghost locked asresolvedand limited conversation to collaboratorsAug 29, 2021
This pull request wasclosed.
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

No one assigned

Labels

area-System.IOtenet-performancePerformance related issue

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

3 participants

@pentp@stephentoub@adamsitnik
[8]ページ先頭
©2009-2025 Movatter.jp