NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Improve Guid parsing performance for "D", "N", "B", and "P"#55792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

stephentoub merged 2 commits intodotnet:mainfromstephentoub:guidparse

Jul 22, 2021

Merged

Improve Guid parsing performance for "D", "N", "B", and "P"#55792

stephentoub merged 2 commits intodotnet:mainfromstephentoub:guidparse

Jul 22, 2021

Conversation

Copy link

Member

stephentoub commentedJul 16, 2021•
edited
Loading

Method	Toolchain	Mean	Error	StdDev	Ratio
D	\main\corerun.exe	69.87 ns	0.644 ns	0.538 ns	1.00
D	\pr\corerun.exe	38.21 ns	0.097 ns	0.086 ns	0.55

N	\main\corerun.exe	58.43 ns	0.838 ns	0.700 ns	1.00
N	\pr\corerun.exe	37.97 ns	0.207 ns	0.173 ns	0.65

B	\main\corerun.exe	69.52 ns	0.337 ns	0.281 ns	1.00
B	\pr\corerun.exe	39.20 ns	0.190 ns	0.169 ns	0.56

P	\main\corerun.exe	69.50 ns	0.260 ns	0.243 ns	1.00
P	\pr\corerun.exe	39.92 ns	0.139 ns	0.116 ns	0.57

InvalidD	\main\corerun.exe	73.47 ns	0.656 ns	0.614 ns	1.00
InvalidD	\pr\corerun.exe	42.47 ns	0.142 ns	0.133 ns	0.58

WeirdD	\main\corerun.exe	68.45 ns	0.214 ns	0.190 ns	1.00
WeirdD	\pr\corerun.exe	102.44 ns	0.643 ns	0.537 ns	1.50

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;[MemoryDiagnoser]publicclassProgram{publicstaticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);privatestring_d,_b,_p,_n;privatestring_invalidD;privatestring_weirdD;[GlobalSetup]publicvoidSetup(){Guidg=Guid.NewGuid();_d=g.ToString("D");_b=g.ToString("B");_p=g.ToString("P");_n=g.ToString("N");_invalidD=_d[..^1]+"Z";_weirdD="+"+_d[1..];}[Benchmark]publicboolD()=>Guid.TryParseExact(_d,"D",out_);[Benchmark]publicboolN()=>Guid.TryParseExact(_n,"N",out_);[Benchmark]publicboolB()=>Guid.TryParseExact(_b,"B",out_);[Benchmark]publicboolP()=>Guid.TryParseExact(_p,"P",out_);[Benchmark]publicboolInvalidD()=>Guid.TryParseExact(_invalidD,"D",out_);[Benchmark]publicboolWeirdD()=>Guid.TryParseExact(_weirdD,"D",out_);}

stephentoub requested a review fromGrabYourPitchforks

July 16, 2021 01:08

Copy link

ghost commentedJul 16, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly onearea label.

Copy link

MemberAuthor

stephentoub commentedJul 16, 2021

@uweigand, I would not be at all surprised if I got the endianness wrong here. Can you take a look?

uweigand reviewed

Jul 16, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Guid.cs OutdatedShow resolvedHide resolved

Improve Guid parsing for "D", "N", "B", and "P"

315b04b

stephentoub force-pushed theguidparse branch froma01deeb to315b04bCompare

July 16, 2021 15:36

hopperpl reviewed

Jul 17, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Guid.cs OutdatedShow resolvedHide resolved

Update src/libraries/System.Private.CoreLib/src/System/Guid.cs

f7c9437

jcdickinson reviewed

Jul 19, 2021

View reviewed changes

src/libraries/System.Private.CoreLib/src/System/Guid.csShow resolvedHide resolved

stephentoub added the area-System.Runtime label

Jul 20, 2021

Copy link

ghost commentedJul 20, 2021

Tagging subscribers to this area: @dotnet/area-system-runtime
See info inarea-owners.md if you want to be subscribed.

Issue Details

Method	Toolchain	Mean	Error	StdDev	Ratio
D	\main\corerun.exe	69.87 ns	0.644 ns	0.538 ns	1.00
D	\pr\corerun.exe	38.21 ns	0.097 ns	0.086 ns	0.55

N	\main\corerun.exe	58.43 ns	0.838 ns	0.700 ns	1.00
N	\pr\corerun.exe	37.97 ns	0.207 ns	0.173 ns	0.65

B	\main\corerun.exe	69.52 ns	0.337 ns	0.281 ns	1.00
B	\pr\corerun.exe	39.20 ns	0.190 ns	0.169 ns	0.56

P	\main\corerun.exe	69.50 ns	0.260 ns	0.243 ns	1.00
P	\pr\corerun.exe	39.92 ns	0.139 ns	0.116 ns	0.57

InvalidD	\main\corerun.exe	73.47 ns	0.656 ns	0.614 ns	1.00
InvalidD	\pr\corerun.exe	42.47 ns	0.142 ns	0.133 ns	0.58

WeirdD	\main\corerun.exe	68.45 ns	0.214 ns	0.190 ns	1.00
WeirdD	\pr\corerun.exe	102.44 ns	0.643 ns	0.537 ns	1.50

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem;[MemoryDiagnoser]publicclassProgram{publicstaticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args);privatestring_d,_b,_p,_n;privatestring_invalidD;privatestring_weirdD;[GlobalSetup]publicvoidSetup(){Guidg=Guid.NewGuid();_d=g.ToString("D");_b=g.ToString("B");_p=g.ToString("P");_n=g.ToString("N");_invalidD=_d[..^1]+"Z";_weirdD="+"+_d[1..];}[Benchmark]publicboolD()=>Guid.TryParseExact(_d,"D",out_);[Benchmark]publicboolN()=>Guid.TryParseExact(_n,"N",out_);[Benchmark]publicboolB()=>Guid.TryParseExact(_b,"B",out_);[Benchmark]publicboolP()=>Guid.TryParseExact(_p,"P",out_);[Benchmark]publicboolInvalidD()=>Guid.TryParseExact(_invalidD,"D",out_);[Benchmark]publicboolWeirdD()=>Guid.TryParseExact(_weirdD,"D",out_);}