- Notifications
You must be signed in to change notification settings - Fork5.2k
Raise the max size poolable by ArrayPool#55621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedJul 14, 2021
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly onearea label. |
davidfowl commentedJul 14, 2021
I have so much reactionary code to change 😂 |
4421144 to457144dCompareWe previously set an arbitrary cut-off of 2MB max array size. That was before we would trim arrays in response to memory pressure. This now raises the limit as high as we can while maintaining the current power-of-two-based scheme.
stephentoub commentedJul 14, 2021
Just to confirm, not code that will break because of this, but code where you were working around the lack of this and now don't have to, yes? |
davidfowl commentedJul 14, 2021
Correct. |
We previously set an arbitrary cut-off of 1MB max array size. That was before we would trim arrays in response to memory pressure. This now raises the limit as high as we can while maintaining the current power-of-two-based scheme.
Contributes to#12800
cc:@jkotas,@Maoni0