- Notifications
You must be signed in to change notification settings - Fork5.2k
Simplify PosixSignalRegistration implementation on Unix#55552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
jkotas left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Unix.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
Bring it onto the same scheme as the Windows implementation.
MaximLipnin commentedJul 13, 2021
@stephentoub Can these changes fix#55563 ? |
stephentoub commentedJul 13, 2021
No |
...es/System.Private.CoreLib/src/System/Runtime/InteropServices/PosixSignalRegistration.Unix.cs OutdatedShow resolvedHide resolved
Uh oh!
There was an error while loading.Please reload this page.
tmds left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks!
Bring it onto the same scheme as the Windows implementation.
cc:@tmds,@jkotas