Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Change RandomAccess.Write* methods to perform complete writes#55490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@stephentoub
Copy link
Member

Fixes#55473
Replaces#55474

@carlossanlop,@jozkee,@jeffhandley, I would like to get this in for Preview 7.

pentp reacted with thumbs up emoji
@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-io
See info inarea-owners.md if you want to be subscribed.

Issue Details

Fixes#55473
Replaces#55474

@carlossanlop,@jozkee,@jeffhandley, I would like to get this in for Preview 7.

Author:stephentoub
Assignees:-
Labels:

area-System.IO,new-api-needs-documentation

Milestone:-

Copy link
Member

@adamsitnikadamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, thanks for saving us! Now I can truly log off for the vacations.

@stephentoubstephentoubforce-pushed thefixrandomaccesswritereturn branch froma8b21cc to3fcce84CompareJuly 12, 2021 16:41
@stephentoubstephentoub merged commitda7bce7 intodotnet:mainJul 12, 2021
@stephentoubstephentoub deleted the fixrandomaccesswritereturn branchJuly 12, 2021 23:39
Copy link
Member

@adamsitnikadamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just finished re-reading the PR after getting back from vacation. Once again big thanks for all your help@stephentoub !

Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

RandomAccess.Write methods should perform full writes

2 participants

@stephentoub@adamsitnik
[8]ページ先頭
©2009-2025 Movatter.jp