Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

One shot CFB#55480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
bartonjs merged 21 commits intodotnet:mainfromvcsjones:2406-one-shot-cfb
Jul 13, 2021
Merged

One shot CFB#55480

bartonjs merged 21 commits intodotnet:mainfromvcsjones:2406-one-shot-cfb
Jul 13, 2021

Conversation

@vcsjones
Copy link
Member

@vcsjonesvcsjones commentedJul 11, 2021•
edited
Loading

This implements CFB one shots.

Some implementation notes:

  1. As discovered inPersisted-key AesCng in CFB mode always uses CFB8 #55477, CFB128 and CFB64 do not work with persisted CNG keys, they always work in CFB8 mode today. Rather than replicating this wrong behavior, theAesCng andTripleDESCng one shots will throw if the key is persisted and the feedback size is other than 8. This limitation can be removed, if it is possible, when the linked issue is solved.
  2. This does not change the behavior of theICryptoTransform CFB implementation. The CNG CFB128 /CFB64 persisted-key remain as-is (using CFB8).
  3. RC2 does not support CFB at all, so the implementation throws.

Closes#2406

@ghost
Copy link

Note regarding thenew-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

Tagging subscribers to this area:@bartonjs,@vcsjones,@krwq,@GrabYourPitchforks
See info inarea-owners.md if you want to be subscribed.

Issue Details

This implements CFB one shots.

Some implementation notes:

  1. As discovered inPersisted-key AesCng in CFB mode always uses CFB8 #55477, CFB128 and CFB64 do not work with persisted CNG keys, they always work in CFB8 mode today. Rather than replicating this wrong behavior,AesCng andTripleDESCng will throw if the key is persisted and the feedback size is other than 8. This limitation can be removed, if it is possible, when the linked issue is solved.
  2. RC2 does not support CFB at all, so the implementation throws.

Closes#2406

Author:vcsjones
Assignees:-
Labels:

area-System.Security,new-api-needs-documentation

Milestone:-

@vcsjones
Copy link
MemberAuthor

Mono failures should be fixed by#55482.

@bartonjs
Copy link
Member

Looks like all I had were a couple of nitpicky things. Nice work.

@bartonjs
Copy link
Member

/azp run runtime-libraries-coreclr outerloop

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vcsjones
Copy link
MemberAuthor

Seems like Pipeline's NuGet feed is cranky.

bartonjs reacted with thumbs up emoji

@bartonjs
Copy link
Member

The outerloop failures aren't related, just waiting on the Linux-Debug leg to finish.

@bartonjsbartonjs merged commit2d3acc6 intodotnet:mainJul 13, 2021
@vcsjonesvcsjones deleted the 2406-one-shot-cfb branchJuly 13, 2021 18:33
@ghostghost locked asresolvedand limited conversation to collaboratorsAug 12, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@bartonjsbartonjsbartonjs approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

One-shot AES CBC and ECB

2 participants

@vcsjones@bartonjs
[8]ページ先頭
©2009-2025 Movatter.jp