Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Use RandomAccess/File.OpenHandle in a few more places#55150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
stephentoub merged 1 commit intodotnet:mainfromstephentoub:morehandle
Jul 9, 2021

Conversation

@stephentoub
Copy link
Member

Places where we don't need to pay for the FileStream and the access pattern is easily replaced.

@ghostghost added the area-System.IO labelJul 4, 2021
@ghost
Copy link

Tagging subscribers to this area: @dotnet/area-system-io
See info inarea-owners.md if you want to be subscribed.

Issue Details

Places where we don't need to pay for the FileStream and the access pattern is easily replaced.

Author:stephentoub
Assignees:-
Labels:

area-System.IO

Milestone:-

@stephentoub
Copy link
MemberAuthor

stephentoub commentedJul 4, 2021•
edited
Loading

This fails because of MS_IO_REDIST, and it's too annoying to use ifdefs everywhere for it. We should really consider stopping building this package.

cc:@adamsitnik

adamsitnik and pentp reacted with thumbs up emoji

@stephentoub
Copy link
MemberAuthor

Updated with undos for the File changes that would have required large ifdefs.

@adamsitnik
Copy link
Member

This fails because of MS_IO_REDIST, and it's too annoying to use ifdefs everywhere for it. We should really consider stopping building this package.

We plan to reevaluate this package for .NET 7 and hopefully remove it#54919 (comment) cc@jeffhandley

Copy link
Member

@adamsitnikadamsitnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM, I hope that you enjoyed using the new APIs ;)

Places where we don't need to pay for the FileStream and the access pattern is easily replaced.
@stephentoubstephentoub merged commitfe9005f intodotnet:mainJul 9, 2021
@stephentoubstephentoub deleted the morehandle branchJuly 9, 2021 23:47
@ghostghost locked asresolvedand limited conversation to collaboratorsAug 9, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@adamsitnikadamsitnikadamsitnik approved these changes

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stephentoub@adamsitnik
[8]ページ先頭
©2009-2025 Movatter.jp