usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Columns;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Diagnosers;usingBenchmarkDotNet.Reports;usingBenchmarkDotNet.Running;usingPerfolizer.Horology;usingSystem;usingSystem.Globalization;usingSystem.IO;usingSystem.Security.Cryptography;[MemoryDiagnoser]publicclassProgram{publicstaticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args,DefaultConfig.Instance.WithSummaryStyle(newSummaryStyle(CultureInfo.InvariantCulture,printUnitsInHeader:false,sizeUnit:SizeUnit.B,timeUnit:TimeUnit.Nanosecond,printZeroValuesInContent:true)));privatebyte[]_data=RandomNumberGenerator.GetBytes(10_000_000);privateMemoryStream_destination=newMemoryStream();[Benchmark]publicvoidEncode(){_destination.Position=0;using(vartoBase64=newToBase64Transform())using(varstream=newCryptoStream(_destination,toBase64,CryptoStreamMode.Write,leaveOpen:true)){Span<byte>remaining=_data;while(!remaining.IsEmpty){Span<byte>toWrite=remaining.Slice(0,Math.Min(4096,remaining.Length));stream.Write(toWrite);remaining=remaining.Slice(toWrite.Length);}}}}

stephentoub added the area-System.Security label

Jul 2, 2021

stephentoub added this to the6.0.0 milestone

Jul 2, 2021

Copy link

ghost commentedJul 2, 2021

Tagging subscribers to this area:@bartonjs,@vcsjones,@krwq,@GrabYourPitchforks
See info inarea-owners.md if you want to be subscribed.

Issue Details

Fixes#55029

Method	Toolchain	Mean	Ratio	Allocated
Encode	\main\corerun.exe	107,747,075.7 ns	1.00	3,686 B
Encode	\pr\corerun.exe	2,269,515.9 ns	0.02	210 B

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Configs;usingBenchmarkDotNet.Running;usingSystem;usingBenchmarkDotNet.Diagnosers;usingPerfolizer.Horology;usingBenchmarkDotNet.Columns;usingSystem.Globalization;usingBenchmarkDotNet.Reports;usingSystem.Security.Cryptography;usingSystem.IO;[MemoryDiagnoser]publicclassProgram{publicstaticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssembly(typeof(Program).Assembly).Run(args,DefaultConfig.Instance.WithSummaryStyle(newSummaryStyle(CultureInfo.InvariantCulture,printUnitsInHeader:false,sizeUnit:SizeUnit.B,timeUnit:TimeUnit.Nanosecond,printZeroValuesInContent:true)));privatebyte[]_data=RandomNumberGenerator.GetBytes(10_000_000);privateMemoryStream_destination=newMemoryStream();[Benchmark]publicvoidEncode(){_destination.Position=0;using(vartoBase64=newToBase64Transform())using(varstream=newCryptoStream(_destination,toBase64,CryptoStreamMode.Write,leaveOpen:true)){Span<byte>remaining=_data;while(!remaining.IsEmpty){Span<byte>toWrite=remaining.Slice(0,Math.Min(4096,remaining.Length));stream.Write(toWrite);remaining=remaining.Slice(toWrite.Length);}}}}

Author:	stephentoub
Assignees:	-
Labels:	`area-System.Security`
Milestone:	6.0.0

GrabYourPitchforks reviewed

Jul 2, 2021

View reviewed changes

...s/System.Security.Cryptography.Encoding/src/System/Security/Cryptography/Base64Transforms.cs OutdatedShow resolvedHide resolved

GrabYourPitchforks reviewed

Jul 2, 2021

View reviewed changes

...s/System.Security.Cryptography.Encoding/src/System/Security/Cryptography/Base64Transforms.cs OutdatedShow resolvedHide resolved

bartonjs reviewed

Jul 2, 2021

View reviewed changes

...s/System.Security.Cryptography.Encoding/src/System/Security/Cryptography/Base64Transforms.cs OutdatedShow resolvedHide resolved

Tornhoof reviewed

Jul 2, 2021

View reviewed changes

src/libraries/System.Security.Cryptography.Encoding/tests/Base64TransformsTests.cs OutdatedShow resolvedHide resolved

Copy link

MemberAuthor

stephentoub commentedJul 2, 2021

I'm realizing now I misunderstood the contract, and the implementation needs to be much more complex, to handle cases where more input is provided than can fit into the output space provided... I was only encoding what would fit, but it appears the contract actually requires the remaining input data to be saved off for later.

stephentoub closed this

Jul 2, 2021

Copy link

MemberAuthor

stephentoub commentedJul 2, 2021

Turns out the implementation doesn't need to be more complex as it can make simplifying assumptions about the inputs, ala what UniversalCryptoTransform does. And since this never previously supported anything other than one input block that entirely fit into the output, this won't be a breaking change. I'll fix up the input validation accordingly.