Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Loop alignment: Handle blocks added in loop as part of split edges of LSRA#55047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
kunalspathak merged 4 commits intodotnet:mainfromkunalspathak:loopalign-splitedge
Jul 8, 2021

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathakkunalspathak commentedJul 1, 2021•
edited
Loading

If there are new blocks added by LSRA that modifies the flow of blocks that are in loop, then make sure that we do not align such
loops if they intersect with the last aligned loop.

Fixes some manifestation of#47094.

If there are new blocks added by LSRA and modifies the flow ofblocks that are in loop, then make sure that we do not align suchloops if they intersect with last aligned loop.
@ghostghost added the area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI labelJul 1, 2021
@kunalspathakkunalspathak marked this pull request as ready for reviewJuly 2, 2021 16:50
@kunalspathak
Copy link
ContributorAuthor

@dotnet/jit-contrib

@kunalspathakkunalspathak changed the titleHandle blocks added in loop as part of split edges of LSRALoop alignment: Handle blocks added in loop as part of split edges of LSRAJul 2, 2021
Copy link
Contributor

@BruceForstallBruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Any asm diffs?

@kunalspathak
Copy link
ContributorAuthor

Any asm diffs?

No asm diffs. The scenario mainly come in jitstressregs mode where we end up adding new blocks for resolution.

@ghost
Copy link

Hello@kunalspathak!

Because this pull request has theauto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn morehere.

@kunalspathak
Copy link
ContributorAuthor

Formatting errors will be addressed in#55320

@kunalspathak
Copy link
ContributorAuthor

One of the failure is#55315

@kunalspathakkunalspathak merged commitb2a5499 intodotnet:mainJul 8, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsAug 7, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

1 more reviewer

@BruceForstallBruceForstallBruceForstall approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclrCLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kunalspathak@BruceForstall
[8]ページ先頭
©2009-2025 Movatter.jp