Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[wasm] Build static components; include hot_reload in runtime#54568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@lambdageek
Copy link
Member

Workaround until#54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing

@ghostghost added the area-Build-mono labelJun 22, 2021
@lambdageeklambdageek added the arch-wasmWebAssembly architecture labelJun 22, 2021
@ghost
Copy link

Tagging subscribers to 'arch-wasm':@lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Workaround until#54565 is fixed
Build the runtime always with support for hot_reload, and without diagnostics_tracing

Author:lambdageek
Assignees:-
Labels:

arch-wasm,area-Build-mono

Milestone:-

@lambdageek
Copy link
MemberAuthor

/cc@lateralusX

@lambdageek
Copy link
MemberAuthor

This also needs to go into .NET 6 Preview 6

@radical
Copy link
Member

Does this enable, or fix something?

@lambdageek
Copy link
MemberAuthor

Does this enable, or fix something?

Yea it fixes hot reload on .NET 6 P6

@radical
Copy link
Member

Does this enable, or fix something?

Yea it fixes hot reload on .NET 6 P6

Is there a test that we can enable with this, so we get validation too?

Workaround untildotnet#54565 is fixedBuild the runtime always with support for hot_reload, and without diagnostics_tracing
@lambdageeklambdageekforce-pushed thefix-wasm-hot_reload-component branch fromb243253 tobe8a1e8CompareJune 22, 2021 18:49
thaystgand others added2 commitsJune 22, 2021 16:10
Just check that the capabilities are non-empty which is a good proxy for hotreload being enabled in the runtime.
@lambdageeklambdageekforce-pushed thefix-wasm-hot_reload-component branch from74ad995 to5da0bdeCompareJune 22, 2021 20:42
@lambdageek
Copy link
MemberAuthor

@radical I added a new functional test for the browser. didn't try very hard to override all the build lane stuff, but at least for a default./build.sh --os browser -c Release and running the test withdotnet.sh build /p:TargetOS=browser /p:TargetArchitecture=wasm /t:Test works for me.

@radical
Copy link
Member

wasm failure is#53957

@lambdageeklambdageekforce-pushed thefix-wasm-hot_reload-component branch from303e48e to5a084cfCompareJune 23, 2021 17:13
Copy link
Member

@radicalradical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, just nits, whatever bits I could review. The env vars stuff should be doable in the project file itself, but nothing to block this PR over.

lambdageek reacted with heart emoji
Condition="'$(TargetOS)' == 'Browser'">
<ItemGroup>
<!-- FIXME: this belongs in eng/testing/tests.wasm.targets -->
<!-- FIXME: Can we do something on the Content items in the referenced projects themselves to get this for free? -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

soon ;)

lambdageek reacted with laugh emoji
@lambdageek
Copy link
MemberAuthor

/backport to release/6.0-preview6

@github-actions
Copy link
Contributor

Started backporting to release/6.0-preview6:https://github.com/dotnet/runtime/actions/runs/965256876

@lambdageeklambdageek merged commit93f407d intodotnet:mainJun 24, 2021
steveisok pushed a commit that referenced this pull requestJun 24, 2021
…load in runtime (#54622)Backport of#54568 to release/6.0-preview6Workaround until#54565 is fixedBuild the runtime always with support for hot_reload, and without diagnostics_tracingCo-authored-by: Aleksey Kliger <alklig@microsoft.com>Co-authored-by: Thays Grazia <thaystg@gmail.com>
thaystg added a commit to thaystg/runtime that referenced this pull requestJun 24, 2021
…bugger2* origin/main: (107 commits)  Disable MacCatalyst arm64 PR test runs on staging pipeline (dotnet#54678)  [WASM] Fix async/await in config loading (dotnet#54652)  Fix for heap_use_after_free flagged by sanitizer (dotnet#54679)  [wasm] Bump emscripten to 2.0.23 (dotnet#53603)  Fix compiler references when building inside VS (dotnet#54614)  process more TLS frames at one when available (dotnet#50815)  Add PeriodicTimer (dotnet#53899)  UdpClient with span support (dotnet#53429)  exclude fragile tests (dotnet#54671)  get last error before calling a method that might fail as well (dotnet#54667)  [FileStream] add tests for device and UNC paths (dotnet#54545)  Fix sporadic double fd close (dotnet#54660)  Remove Version.Clone from AssemblyName.Clone (dotnet#54621)  [wasm] Enable fixed libraries tests (dotnet#54641)  [wasm] Fix blazor/aot builds (dotnet#54651)  [mono][wasm] Fix compilation error on wasm (dotnet#54659)  Fix telemetry for Socket connects to Dns endpoints (dotnet#54071)  [wasm] Build static components; include hot_reload in runtime (dotnet#54568)  [wasm][debugger] Reuse debugger-agent on wasm debugger (dotnet#52300)  Put Crossgen2 in sync withdotnet#54235 (dotnet#54438)  ...
@ghostghost locked asresolvedand limited conversation to collaboratorsJul 24, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@radicalradicalradical approved these changes

@marek-safarmarek-safarAwaiting requested review from marek-safar

@lewinglewingAwaiting requested review from lewinglewing is a code owner

Assignees

No one assigned

Labels

arch-wasmWebAssembly architecturearea-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lambdageek@radical@thaystg
[8]ページ先頭
©2009-2025 Movatter.jp