NotificationsYou must be signed in to change notification settings
Fork5.2k
Star17.2k

Special-case no attributes in GetCustomAttributeData#54405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

jkotas merged 1 commit intodotnet:mainfromstephentoub:emptycustomattrs

Jun 21, 2021

Merged

Special-case no attributes in GetCustomAttributeData#54405

jkotas merged 1 commit intodotnet:mainfromstephentoub:emptycustomattrs

Jun 21, 2021

Conversation

Copy link

Member

stephentoub commentedJun 18, 2021

It's common to ask for attribute information on members that don't have attributes (which you only discover by asking).

usingBenchmarkDotNet.Attributes;usingBenchmarkDotNet.Running;usingSystem.Collections.Generic;usingSystem.Reflection;[MemoryDiagnoser]publicclassProgram{staticvoidMain(string[]args)=>BenchmarkSwitcher.FromAssemblies(new[]{typeof(Program).Assembly}).Run(args);privateMethodInfo_mi=typeof(Program).GetMethod("MyMethod");publicvoidMyMethod(){}[Benchmark]publicIList<CustomAttributeData>Get()=>_mi.GetCustomAttributesData();}