- Notifications
You must be signed in to change notification settings - Fork5.2k
Make some Brotli p/invokes blittable#54029
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedJun 10, 2021
Tagging subscribers to this area: @dotnet/area-system-io-compression Issue DetailsFound that two of the Brotli p/invokes could easily be made blittable (inlinable during JIT) while prototyping a cc@AaronRobinsonMSFT@jkoritzinsky
|
| [DllImport(Libraries.CompressionNative)] | ||
| internalstaticexternunsafeboolBrotliDecoderDecompress(nuintavailableInput,byte*inBytes,refnuintavailableOutput,byte*outBytes); | ||
| internalstaticexternunsafeintBrotliDecoderDecompress(nuintavailableInput,byte*inBytes,nuint*availableOutput,byte*outBytes); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we make all of PInvokes in this file to returnint for consistency?
Also, would it make sense to useBOOL to make it clear that this is returning boolean value?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Are you talking about thatInterop.BOOL enum?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I believe so.
Found that two of the Brotli p/invokes could easily be made blittable (inlinable during JIT) while prototyping a
DllImportsource generator.cc@AaronRobinsonMSFT@jkoritzinsky