Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Handle Counter Polling Interval of 0#53836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

@josalem
Copy link
Contributor

Fixes#53564

  • default internal state to DateTime.MaxValue
  • re-check IsEnabled after not holding lock
  • add test for setting interval to 0

This will need to be backported to 3.1and 5.0.

CC@tommcdon

tommcdon reacted with hooray emoji
* default internal state to DateTime.MaxValue* re-check IsEnabled after not holding lock* add test for setting interval to 0
@josalemjosalem added this to the6.0.0 milestoneJun 7, 2021
@josalemjosalem requested review froma team,davmason andnoahfalkJune 7, 2021 20:52
@josalemjosalem self-assigned thisJun 7, 2021
@ghost
Copy link

Tagging subscribers to this area:@tarekgh,@tommcdon,@pjanotti
See info inarea-owners.md if you want to be subscribed.

Issue Details

Fixes#53564

  • default internal state to DateTime.MaxValue
  • re-check IsEnabled after not holding lock
  • add test for setting interval to 0

This will need to be backported to 3.1and 5.0.

CC@tommcdon

Author:josalem
Assignees:josalem
Labels:

area-System.Diagnostics.Tracing

Milestone:6.0.0

Copy link
Member

@noahfalknoahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I'm hoping we can go even more targetted, suggestion inline : )

Copy link
Contributor

@davmasondavmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This version LGTM

josalem reacted with thumbs up emoji
@lateralusX
Copy link
Member

Looks like I managed to repro/investigate/fix this issue when testing on iOS in parallel to this fix/investigation,#53887.

Copy link
Member

@noahfalknoahfalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@josalemjosalem merged commit207bb77 intodotnet:mainJun 10, 2021
@josalemjosalem deleted the dev/josalem/counter-interval-zero branchJune 10, 2021 22:21
@josalem
Copy link
ContributorAuthor

\backport to release/5.0

@hoyosjs
Copy link
Member

/backport to release/5.0

@github-actions
Copy link
Contributor

Started backporting to release/5.0:https://github.com/dotnet/runtime/actions/runs/926712176

josalem pushed a commit to josalem/coreclr that referenced this pull requestJun 10, 2021
jeffschwMSFT pushed a commit to dotnet/coreclr that referenced this pull requestJun 15, 2021
@ghostghost locked asresolvedand limited conversation to collaboratorsJul 10, 2021
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.

Reviewers

@stephentoubstephentoubstephentoub left review comments

@noahfalknoahfalknoahfalk approved these changes

+1 more reviewer

@davmasondavmasondavmason approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@josalemjosalem

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

EventCounter publishing thread can hang

6 participants

@josalem@lateralusX@hoyosjs@stephentoub@noahfalk@davmason
[8]ページ先頭
©2009-2025 Movatter.jp