- Notifications
You must be signed in to change notification settings - Fork5.2k
[release/6.0-preview5] Add JSON source-gen mode that emits serialization logic#53337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
[release/6.0-preview5] Add JSON source-gen mode that emits serialization logic#53337
Uh oh!
There was an error while loading.Please reload this page.
Conversation
ghost commentedMay 27, 2021
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost commentedMay 27, 2021
Tagging subscribers to this area:@eiriktsarpalis,@layomia |
Uh oh!
There was an error while loading.Please reload this page.
Backport of#53212 to release/6.0-preview5. Contributes to#51945.
/cc@layomia
Customer Impact
This PR adds a new mode to the JSON source generator that emits serialization logic and can improve throughput performance. It is important to have folks try it and give us feedback.
We discussed with ASP.NET - they are supportive of this and don't need to react to the change.
Testing
Tests have been added for new scenarios and there are no regressions to existing tests.
Risk
The risk is minimal. Projects using System.Text.Json without JSON source gen should be unaffected since the vast majority of changes are within the source generator. Projects that use source gen should also have no regressions to existing functionality, and it will be easy to configure the new mode.